Update workflow to use build script#233
Conversation
There was a problem hiding this comment.
Pull request overview
This PR switches the GitHub Actions build workflow from inlined .deb construction to the repository’s scripts/build-deb.sh packaging script (backed by packages/<project> definitions), and updates the README to document the new package layout/behavior and additional supported daemons.
Changes:
- Update
README.mdwith expanded install/config/upgrade/removal documentation and addwalletd+s3dto the supported package list. - Refactor
.github/workflows/build.ymlto build.debartifacts viascripts/build-deb.shand upload/download a unifieddebsartifact for repository publishing.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| README.md | Documents the new packaging behavior (paths, conffiles, upgrades), adds walletd/s3d, and expands usage guidance. |
| .github/workflows/build.yml | Uses scripts/build-deb.sh + packages/<project> definitions instead of hand-assembling .deb contents in the workflow. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Before we merge this we should test this manually at least once as well. e.g. by setting up a linux.sia.dev temporarily on Zeus with the legacy packages. Then install them on a linux machine/vm, play around with them, update the packages, check migrations succeeded and so on.
There was a problem hiding this comment.
Ok, I tested it but not this extensively. I'll set it up on a personal node and share the results. The main question mark for me was that we're ok with conffiles to solve the problems outlined in the referenced issues right.
| - the data directory `/var/lib/hostd` and the log directory `/var/log/hostd` | ||
|
|
||
| The service is installed disabled because the daemon needs credentials | ||
| before it can run. Edit `/etc/hostd/hostd.yml` and fill in the commented |
There was a problem hiding this comment.
Don’t ship a config file. Use hostd config.
peterjan
force-pushed
the
pj/deb-packages
branch
from
6b6e0aa to
f81a230
Compare
peterjan
force-pushed
the
pj/deb-workflow
branch
from
772d254 to
994d44b
Compare
peterjan
force-pushed
the
pj/deb-workflow
branch
from
994d44b to
3826c6b
Compare
Flips the release flow over to the package definitions added in the previous PR and documents the new behaviour.
Fixes #129
Fixes #179