add taskoutput tool use formatter#945
Open
LasmarKhalifa wants to merge 1 commit into
Open
Conversation
This was referenced Jun 6, 2026
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
9ef9ff2 to
a032e94
Compare
c383b7f to
b5f9b74
Compare
juniper-shopify
requested changes
Jun 11, 2026
Comment on lines
+354
to
+357
| timeout_str = if timeout_ms | ||
| secs = timeout_ms / 1000.0 | ||
| secs == secs.to_i ? "#{secs.to_i}s timeout" : "#{secs}s timeout" | ||
| end |
Contributor
There was a problem hiding this comment.
This code is a bit counterintuitive to read. It deserves a short comment like "# don't display decimal values if seconds is a whole number", but even that is clunky.
You can make this clearer and also more elegant with ActiveSupport::NumberHelper
Suggested change
| timeout_str = if timeout_ms | |
| secs = timeout_ms / 1000.0 | |
| secs == secs.to_i ? "#{secs.to_i}s timeout" : "#{secs}s timeout" | |
| end | |
| timeout_str = if timeout_ms | |
| seconds = number_to_rounded(timeout_ms, delimiter: ",", precision: 3, strip_insignificant_zeros: true) | |
| "${seconds}s timeout" | |
| end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

closes #932
Improves the formatting of the taskoutput tool use message.
Current output:

New output:
