Skip to content

[Tests] Remove filesystem mocks in result.test.ts#7820

Draft
gonzaloriestra wants to merge 1 commit into
mainfrom
tests-remove-fs-mocks-store-result-9552238169850303503
Draft

[Tests] Remove filesystem mocks in result.test.ts#7820
gonzaloriestra wants to merge 1 commit into
mainfrom
tests-remove-fs-mocks-store-result-9552238169850303503

Conversation

@gonzaloriestra

Copy link
Copy Markdown
Contributor

This PR refactors the unit tests for writeOrOutputStoreExecuteResult in the @shopify/store package to eliminate filesystem mocks. Following the project's testing strategy, it now uses real filesystem operations within temporary directories provided by inTemporaryDirectory.

Key changes:

  • Removed vi.mock('@shopify/cli-kit/node/fs').
  • Updated tests to use inTemporaryDirectory and joinPath for managing test files.
  • Replaced expect(writeFile).toHaveBeenCalledWith(...) assertions with expect(await readFile(outputPath)).toContain(...).
  • Verified that all tests pass and that linting/type-checking/knip are clean.

PR created automatically by Jules for task 9552238169850303503 started by @gonzaloriestra

Refactored packages/store/src/cli/services/store/execute/result.test.ts to use real filesystem operations in temporary directories instead of mocking @shopify/cli-kit/node/fs.

- Imported inTemporaryDirectory, readFile from @shopify/cli-kit/node/fs
- Imported joinPath from @shopify/cli-kit/node/path
- Removed filesystem mocks
- Wrapped relevant tests in inTemporaryDirectory
- Replaced mock assertions with actual file content checks
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label Jun 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant