[Tests] Remove filesystem mocks in result.test.ts#7820
Conversation
Refactored packages/store/src/cli/services/store/execute/result.test.ts to use real filesystem operations in temporary directories instead of mocking @shopify/cli-kit/node/fs. - Imported inTemporaryDirectory, readFile from @shopify/cli-kit/node/fs - Imported joinPath from @shopify/cli-kit/node/path - Removed filesystem mocks - Wrapped relevant tests in inTemporaryDirectory - Replaced mock assertions with actual file content checks
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
This PR refactors the unit tests for
writeOrOutputStoreExecuteResultin the@shopify/storepackage to eliminate filesystem mocks. Following the project's testing strategy, it now uses real filesystem operations within temporary directories provided byinTemporaryDirectory.Key changes:
vi.mock('@shopify/cli-kit/node/fs').inTemporaryDirectoryandjoinPathfor managing test files.expect(writeFile).toHaveBeenCalledWith(...)assertions withexpect(await readFile(outputPath)).toContain(...).PR created automatically by Jules for task 9552238169850303503 started by @gonzaloriestra