[Refactor] Use uniq helper in AppManagementClient#7818
Conversation
Replace manual Set deduplication with the uniq helper from @shopify/cli-kit/common/array in allowedTemplates function. Also use .flatMap() instead of .map().flat() for conciseness.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
WHY are these changes introduced?
Following the repository's preference for using shared utility functions over manual implementations for common operations like array deduplication.
WHAT is this pull request doing?
Refactored
packages/app/src/cli/utilities/developer-platform-client/app-management-client.tsto replace manualSetdeduplication with theuniqhelper from@shopify/cli-kit/common/arrayand use.flatMap()for cleaner nested array flattening.How to test your changes?
CI
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset addPR created automatically by Jules for task 2931833342598507428 started by @gonzaloriestra