Skip to content

Make everyday Nx checks cacheable #7813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
isaacroldan wants to merge 1 commit into
base: 06-15-fix_nx_build_output_paths
Choose a base branch
from
+26 −28
Draft

Make everyday Nx checks cacheable #7813

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions .github/workflows/tests-main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@ jobs:
timeout-minutes: 30
strategy:
matrix:
os: [ 'ubuntu-latest', 'windows-latest', 'macos-latest' ]
node: [ '22.12.0', '24.1.0', '26.1.0' ]
os: ['ubuntu-latest', 'windows-latest', 'macos-latest']
node: ['22.12.0', '24.1.0', '26.1.0']
steps:
- uses: actions/checkout@v6
name: Checkout [${{ github.ref_name }}]
Expand All @@ -43,23 +43,23 @@ jobs:
with:
node-version: ${{ matrix.node }}
- name: Build
run: pnpm nx run-many --all --skip-nx-cache --target=build --output-style=stream
run: pnpm nx run-many --all --target=build --output-style=stream
if: ${{ matrix.os == 'ubuntu-latest' && matrix.node == '26.1.0' }}
- name: Lint
run: pnpm nx run-many --all --skip-nx-cache --target=lint --output-style=stream
run: pnpm nx run-many --all --target=lint --output-style=stream
if: ${{ matrix.os == 'ubuntu-latest' && matrix.node == '26.1.0' }}
- name: Type-check
run: pnpm nx run-many --all --skip-nx-cache --target=type-check --output-style=stream
run: pnpm nx run-many --all --target=type-check --output-style=stream
if: ${{ matrix.os == 'ubuntu-latest' && matrix.node == '26.1.0' }}
- name: Bundle
run: pnpm nx run-many --all --skip-nx-cache --target=bundle --output-style=stream
run: pnpm nx run-many --all --target=bundle --output-style=stream
if: ${{ matrix.os == 'ubuntu-latest' && matrix.node == '26.1.0' }}
- name: Unit tests
run: pnpm vitest run ${{ env.POOL_OPTIONS }}
env:
POOL_OPTIONS: ${{ matrix.os == 'macos-latest' && '--pool forks' || '' }}
VITEST_MIN_THREADS: "1"
VITEST_MAX_THREADS: "4"
VITEST_MIN_THREADS: '1'
VITEST_MAX_THREADS: '4'
- name: Send Slack notification on failure
uses: slackapi/slack-github-action@007b2c3c751a190b6f0f040e47ed024deaa72844 # v1.23.0
if: ${{ failure() && !cancelled() }}
Expand Down
28 changes: 14 additions & 14 deletions .github/workflows/tests-pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ jobs:
with:
node-version: ${{ env.DEFAULT_NODE_VERSION }}
- name: Type check
run: pnpm nx run-many --all --skip-nx-cache --target=type-check --output-style=stream
run: pnpm nx run-many --all --target=type-check --output-style=stream

lint:
name: 'Lint'
Expand All @@ -52,7 +52,7 @@ jobs:
with:
node-version: ${{ env.DEFAULT_NODE_VERSION }}
- name: Lint
run: pnpm nx run-many --all --skip-nx-cache --target=lint --output-style=stream
run: pnpm nx run-many --all --target=lint --output-style=stream

bundle:
name: 'Bundle'
Expand All @@ -69,9 +69,9 @@ jobs:
with:
node-version: ${{ env.DEFAULT_NODE_VERSION }}
- name: 'Build'
run: pnpm nx run-many --all --skip-nx-cache --target=build --output-style=stream
run: pnpm nx run-many --all --target=build --output-style=stream
- name: 'Bundle'
run: pnpm nx run-many --all --skip-nx-cache --target=bundle --output-style=stream
run: pnpm nx run-many --all --target=bundle --output-style=stream

knip:
name: 'Knip (unused code check)'
Expand Down Expand Up @@ -156,9 +156,9 @@ jobs:
timeout-minutes: 30
strategy:
matrix:
os: [ 'ubuntu-latest', 'windows-latest', 'macos-latest' ]
node: [ '22.12.0', '24.1.0', '26.1.0' ]
shard: [ '' ]
os: ['ubuntu-latest', 'windows-latest', 'macos-latest']
node: ['22.12.0', '24.1.0', '26.1.0']
shard: ['']
include:
# Add sharding for Windows jobs to reduce wall-clock time
- os: windows-latest
Expand Down Expand Up @@ -205,11 +205,11 @@ jobs:
env:
POOL_OPTIONS: ${{ matrix.os == 'macos-latest' && '--pool forks' || '' }}
SHARD_OPTIONS: ${{ matrix.shard && format('--shard {0}', matrix.shard) || '' }}
VITEST_MIN_THREADS: "1"
VITEST_MAX_THREADS: "4"
VITEST_MIN_THREADS: '1'
VITEST_MAX_THREADS: '4'

unit-tests-gate:
name: "Unit tests"
name: 'Unit tests'
needs: unit-tests
if: always()
runs-on: ubuntu-latest
Expand All @@ -220,7 +220,7 @@ jobs:
run: exit 1

e2e-tests:
name: "E2E tests (shard ${{ matrix.shard }})"
name: 'E2E tests (shard ${{ matrix.shard }})'
if: github.event_name == 'merge_group' || github.event.pull_request.head.repo.full_name == github.repository
runs-on: ubuntu-latest
timeout-minutes: 20
Expand All @@ -240,7 +240,7 @@ jobs:
with:
node-version: ${{ env.PLAYWRIGHT_NODE_VERSION }}
- name: Build
run: pnpm nx run-many --all --skip-nx-cache --target=build --output-style=stream
run: pnpm nx run-many --all --target=build --output-style=stream
- name: Install Playwright Chromium
run: pnpm exec playwright install chromium
working-directory: packages/e2e
Expand Down Expand Up @@ -284,7 +284,7 @@ jobs:
with:
node-version: ${{ env.DEFAULT_NODE_VERSION }}
- name: Build
run: pnpm nx run-many --all --skip-nx-cache --target=build --output-style=stream
run: pnpm nx run-many --all --target=build --output-style=stream
- name: Type-diff
working-directory: workspace
id: type-diff
Expand Down Expand Up @@ -316,7 +316,7 @@ jobs:
with:
node-version: ${{ env.DEFAULT_NODE_VERSION }}
- name: Build
run: pnpm nx run-many --all --skip-nx-cache --target=build --output-style=stream
run: pnpm nx run-many --all --target=build --output-style=stream
- name: Check for breaking changes
id: check
run: node workspace/src/major-change-check.js
Expand Down
2 changes: 0 additions & 2 deletions bin/cache-inputs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,13 +23,11 @@ const rootDirectory = dirname(binDirectory)
const nodeVersion = process.version;

const {stdout: typescriptCompilerVersion} = await execa(join(rootDirectory, "node_modules/.bin/tsc"), ['--version'], {cwd: rootDirectory});
const {stdout: gitSha} = await execa("git", ['rev-parse', '--short', 'HEAD'], {cwd: rootDirectory});
const pnpmLockfileContent = (await readFile(join(rootDirectory, "pnpm-lock.yaml"))).toString();

const hashableInputs = [
nodeVersion.trim(),
typescriptCompilerVersion.trim(),
gitSha.trim(),
crypto.createHash('md5').update(pnpmLockfileContent).digest("hex")
]

Expand Down
8 changes: 4 additions & 4 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"build-api-docs": "nx run-many --target=build-api-docs --all --skip-nx-cache",
"build-dev-docs": "pnpm shopify docs generate && sh ./bin/docs/build-dev-docs.sh",
"build:affected": "nx affected --target=build",
"build": "nx run-many --target=build --all --skip-nx-cache",
"build": "nx run-many --target=build --all",
"bundle-for-release": "nx run-many --target=bundle --all --skip-nx-cache",
"changeset-manifests": "changeset version && pnpm install --no-frozen-lockfile && pnpm refresh-manifests && pnpm refresh-readme && pnpm refresh-code-documentation && bin/update-cli-kit-version.js",
"clean": "nx run-many --target=clean --all --skip-nx-cache && nx reset",
Expand All @@ -19,7 +19,7 @@
"lint:affected": "nx affected --target=lint",
"lint:fix:affected": "nx affected --target=lint:fix",
"lint:fix": "nx run-many --target=lint:fix --all --skip-nx-cache",
"lint": "nx run-many --target=lint --all --skip-nx-cache",
"lint": "nx run-many --target=lint --all",
"create-homebrew-pr": "bin/create-homebrew-pr.js",
"refresh-code-documentation": "nx run-many --target=refresh-code-documentation --all --skip-nx-cache",
"refresh-manifests": "nx run-many --target=refresh-manifests --all --skip-nx-cache && bin/prettify-manifests.js && pnpm refresh-readme",
Expand All @@ -29,14 +29,14 @@
"update-observe": "node bin/update-observe.js",
"shopify:run": "node packages/cli/bin/dev.js",
"shopify": "nx build cli && node packages/cli/bin/dev.js",
"test:e2e": "nx run-many --target=build --projects=cli,create-app --skip-nx-cache && pnpm --filter e2e exec playwright test",
"test:e2e": "nx run-many --target=build --projects=cli,create-app && pnpm --filter e2e exec playwright test",
"test:e2e-cleanup": "pnpm --filter e2e exec tsx scripts/cleanup-stores.ts; pnpm --filter e2e exec tsx scripts/cleanup-apps.ts",
"test:e2e-cleanup-stores": "pnpm --filter e2e exec tsx scripts/cleanup-stores.ts",
"test:e2e-cleanup-apps": "pnpm --filter e2e exec tsx scripts/cleanup-apps.ts",
"test:regenerate-snapshots": "packages/e2e/scripts/regenerate-snapshots.sh",
"test": "pnpm vitest run",
"type-check:affected": "nx affected --target=type-check",
"type-check": "nx run-many --target=type-check --all --skip-nx-cache",
"type-check": "nx run-many --target=type-check --all",
"update-bugsnag": "bin/update-bugsnag.js"
},
"devDependencies": {
Expand Down
Loading