Skip to content

Make E2E config link non-interactive#7809

Closed
alfonso-noriega wants to merge 1 commit into
mainfrom
fix-config-link-e2e-prompt
Closed

Make E2E config link non-interactive#7809
alfonso-noriega wants to merge 1 commit into
mainfrom
fix-config-link-e2e-prompt

Conversation

@alfonso-noriega

@alfonso-noriega alfonso-noriega commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

What

Makes the E2E app config link helper run non-interactively when creating the secondary app in app-deploy.spec.ts.

  • Adds hidden app config link --new-app-name support for tests/automation.
  • Treats a provided new app name like a name flag: create a new app directly and skip the create/select + app-name prompts.
  • Updates the E2E helper to use cli.exec() with --organization-id and --new-app-name instead of driving Ink prompts through PTY timing sleeps.

Why

PR #7803 exposed a separate flake: app config link could receive Enter before Ink had consumed/rendered typed prompt input, causing the org selector or app-name prompt to submit stale state. In the failing run the prompt visibly showed the secondary app name, but validation still reported App name can't be empty, and the process eventually timed out.

This removes that timing-sensitive prompt automation from the E2E path.

Testing

  • pnpm --filter @shopify/app vitest src/cli/services/dev/select-app.test.ts src/cli/services/app/config/link.test.ts --run
  • pnpm --filter @shopify/app lint
  • pnpm --filter e2e lint

Attempted, but blocked by existing cli-kit:build missing GraphiQL dependency errors (h3, react-dom/server, @shopify/polaris, @shopify/polaris-icons):

  • pnpm --filter @shopify/app type-check
  • pnpm --filter e2e type-check

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label Jun 15, 2026
@alfonso-noriega alfonso-noriega marked this pull request as ready for review June 15, 2026 13:32
@alfonso-noriega alfonso-noriega requested a review from a team as a code owner June 15, 2026 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant