Skip to content

Make theme store context test deterministic #7806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alfonso-noriega merged 1 commit into from
Jun 16, 2026
+13 −2
Merged

Make theme store context test deterministic #7806

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions packages/theme/src/cli/services/local-storage.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,14 +86,25 @@ describe('local-storage', () => {

const results: Record<string, string | undefined> = {}

let resolveStore1Ready!: () => void
let resolveStore1!: () => void
const store1Ready = new Promise<void>((resolve) => {
resolveStore1Ready = resolve
})
const releaseStore1 = new Promise<void>((resolve) => {
resolveStore1 = resolve
})

await Promise.all([
useThemeStoreContext('store1.myshopify.com', async () => {
await new Promise((resolve) => setTimeout(resolve, 10))
resolveStore1Ready()
await releaseStore1
results.env1 = getThemeStore(storage)
}),
useThemeStoreContext('store2.myshopify.com', async () => {
await new Promise((resolve) => setTimeout(resolve, 5))
await store1Ready
results.env2 = getThemeStore(storage)
resolveStore1()
}),
useThemeStoreContext('store3.myshopify.com', async () => {
results.env3 = getThemeStore(storage)
Expand Down
Loading