Skip to content

Add MiniMax-M3 MXFP8 B300 1k/1k sweep and update image#1937

Open
RohitNagraj wants to merge 2 commits into
mainfrom
minimaxm3-fp8-b300-dynamo-vllm-1k1k
Open

Add MiniMax-M3 MXFP8 B300 1k/1k sweep and update image#1937
RohitNagraj wants to merge 2 commits into
mainfrom
minimaxm3-fp8-b300-dynamo-vllm-1k1k

Conversation

@RohitNagraj

Copy link
Copy Markdown
Collaborator

Adds the 1k/1k sweep for the MiniMax-M3 MXFP8 B300 Dynamo-vLLM config and updates the container image.

…hape 1k/1k layouts

Move both the 1k/1k and 8k/1k MiniMax-M3 MXFP8 B300 Dynamo-vLLM sweeps to
the vllm-minimax-m3-perf image and skip the vLLM monkeypatch on it (the perf
image already carries those fixes). Reshape the 1k/1k disaggregated
prefill/decode layouts.
@github-actions

Copy link
Copy Markdown
Contributor

Thanks for the contribution! For vLLM & SGLang, please ensure that your recipes is similar to the official vLLM recipes and/or the SGLang cookbook

If it is not, please create a PR first before we can merge your single node PR into the master branch. Let's ensure that the documentation is first class such that the entire ML community can benefit from your hard work! Thank you

PR authors are responsible for ensuring that after merging, all GitHub Action jobs fully pass. A lot of the time, failures are just flakes and simply re-running the failed jobs will fix it. If re-running failed jobs is attempted, PR authors are responsible for ensuring it passes. See GitHub's docs on re-running failed jobs: https://docs.github.com/en/actions/how-tos/manage-workflow-runs/re-run-workflows-and-jobs#re-running-failed-jobs-in-a-workflow

As a rule of thumb, generally, PR authors should request a review & get a PR approval from the respective companies' CODEOWNERS before requesting a review from core maintainers.

If additional help is needed, PR authors can reach out to core maintainers over Slack.


感谢你的贡献!对于 vLLM 与 SGLang,请确保你的 recipe 与官方 vLLM recipes 和/或 SGLang cookbook 保持一致

如果不一致,请先创建一个 PR,之后我们才能将你的单节点 PR 合并到 master 分支。让我们确保文档保持一流水准,使整个 ML 社区都能从你的辛勤工作中受益!谢谢

PR 作者有责任确保合并后所有 GitHub Action 任务完全通过。 很多时候失败只是偶发抖动(flake),重新运行失败的任务即可解决。如果选择重新运行失败的任务,PR 作者有责任确保其最终通过。参见 GitHub 关于重新运行失败任务的文档:https://docs.github.com/en/actions/how-tos/manage-workflow-runs/re-run-workflows-and-jobs#re-running-failed-jobs-in-a-workflow

一般而言,PR 作者应先向相应公司的 CODEOWNERS 请求审阅并获得 PR 批准,然后再请求核心维护者审阅。

如需更多帮助,PR 作者可通过 Slack 联系核心维护者。

1 similar comment
@github-actions

Copy link
Copy Markdown
Contributor

Thanks for the contribution! For vLLM & SGLang, please ensure that your recipes is similar to the official vLLM recipes and/or the SGLang cookbook

If it is not, please create a PR first before we can merge your single node PR into the master branch. Let's ensure that the documentation is first class such that the entire ML community can benefit from your hard work! Thank you

PR authors are responsible for ensuring that after merging, all GitHub Action jobs fully pass. A lot of the time, failures are just flakes and simply re-running the failed jobs will fix it. If re-running failed jobs is attempted, PR authors are responsible for ensuring it passes. See GitHub's docs on re-running failed jobs: https://docs.github.com/en/actions/how-tos/manage-workflow-runs/re-run-workflows-and-jobs#re-running-failed-jobs-in-a-workflow

As a rule of thumb, generally, PR authors should request a review & get a PR approval from the respective companies' CODEOWNERS before requesting a review from core maintainers.

If additional help is needed, PR authors can reach out to core maintainers over Slack.


感谢你的贡献!对于 vLLM 与 SGLang,请确保你的 recipe 与官方 vLLM recipes 和/或 SGLang cookbook 保持一致

如果不一致,请先创建一个 PR,之后我们才能将你的单节点 PR 合并到 master 分支。让我们确保文档保持一流水准,使整个 ML 社区都能从你的辛勤工作中受益!谢谢

PR 作者有责任确保合并后所有 GitHub Action 任务完全通过。 很多时候失败只是偶发抖动(flake),重新运行失败的任务即可解决。如果选择重新运行失败的任务,PR 作者有责任确保其最终通过。参见 GitHub 关于重新运行失败任务的文档:https://docs.github.com/en/actions/how-tos/manage-workflow-runs/re-run-workflows-and-jobs#re-running-failed-jobs-in-a-workflow

一般而言,PR 作者应先向相应公司的 CODEOWNERS 请求审阅并获得 PR 批准,然后再请求核心维护者审阅。

如需更多帮助,PR 作者可通过 Slack 联系核心维护者。

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — benchmark recipe sweep update + conditional patch skip for the new perf image.

Extended reasoning...

Overview

This PR moves the MiniMax-M3 MXFP8 B300 Dynamo-vLLM sweep from the minimax-m3-0618 image to vllm-minimax-m3-perf-x86_64-13.0.1-7a67223 across the 1k/1k and 8k/1k recipe YAMLs and .github/configs/nvidia-master.yaml, reshapes the 1k/1k disagg layouts (1P DEP4 + 1D DEP8, 1P DEP2 + 2D TEP4, 1P DEP2 + 6D TEP8, 1P DEP2 + 8D TEP8/TEP4), and adds a conditional in runners/launch_b300-nv.sh to skip the minimax-m3-vllm-fixes.sh monkeypatch when running on the perf image (which already carries those fixes).

Security risks

None. This is benchmark recipe/config work — no auth, crypto, permission, or user-input handling is touched.

Level of scrutiny

Low. The shell change in launch_b300-nv.sh is a tightly scoped conditional with a thorough inline comment explaining why patching is skipped on the perf image. The YAML edits are mechanical container bumps + sweep reshapes confined to MiniMax-M3 B300 benchmarks; the perf-changelog entry documents the move. No production code paths, only benchmarking infra.

Other factors

The bug hunting system found no issues. The shell conditional correctly gates both the SRTCTL_SETUP_SCRIPT assignment and the subsequent cp of the setup script, and the SRTCTL_APPLY_ARGS block downstream already guards --setup-script on a non-empty variable, so the empty-string path is handled consistently end-to-end. This follows the same iteration pattern as the recent d011fb1 commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

1 participant