Add MiniMax supporter quote + randomize carousel starting quote#501
Merged
Conversation
Adds a supporter quote from Ryan Lee (Head of DevRel, MiniMax) to the quotes page, with the MiniMax logo, and includes MiniMax in the homepage quote carousel.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Picks a random starting quote after hydration via a post-mount effect that only sets activeIndex. Because all quotes are grid-stacked at a fixed height and selection toggles opacity, this never shifts layout. SSR stays deterministic (index 0), keeping the crawled HTML stable for SEO. Sequential rotation continues from the random offset, varying appearance order per load.
Oseltamivir
changed the title
Previously only the active quote's logo was in the DOM, so selecting a new company mounted its <img> for the first time and waited on a network fetch + decode before the logo appeared. Render every entry's logo instead: all images load once up front and switching is instant. Layout-neutral — the img matches the previous placeholder's 40px footprint and blocks are grid-stacked.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit e7ea5c1. Configure here.
This comment has been minimized.
This comment has been minimized.
Reverts eager rendering of all carousel logos, which regressed the tested mobile-landing perf guarantee (React emits an image preload per SSR'd <img>, so all 23 logos were preloaded/loaded). Instead, prefetch a company's logo on hover/focus of its org button, warming the cache on user intent so the logo paints instantly on select while the initial load still fetches only the visible logo. Updates the mobile perf test to assert the carousel never eager-loads the full logo set (at most the SSR logo plus the random starting quote's logo), instead of pinning a specific logo that the random start could now surface.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/quotespage and the homepage carousel.Changes
MiniMax quote
quotes-data.tslinking to x.com/RyanLeeMiniMaxpublic/logos/minimax.svg(monochromecurrentColormark from LobeHub, matching siblings renderedgrayscale … dark:invert)'MiniMax'toCAROUSEL_ORGSCarousel randomness (CLS-safe)
activeIndex. Since all quotes are grid-stacked at a fixed height and selection only toggles opacity/visibility, this never shifts layout.Verification
pnpm lint,pnpm fmt,pnpm typecheckall pass (pre-commit hook)Note
Low Risk
Marketing/content and client-only carousel UX with existing CLS/performance guards; no auth, data, or API changes.
Overview
Adds a MiniMax supporter quote (Ryan Lee) to the quotes list and homepage carousel, with a new
minimax.svglogo and'MiniMax'inCAROUSEL_ORGS.The quote carousel picks a random active quote after hydration while SSR still starts at index 0, so layout stays fixed (no CLS) and crawled HTML stays stable. Auto-rotation continues sequentially from that offset. Org strip buttons prefetch logos on hover/focus so switching quotes paints faster without loading every logo on first paint.
The mobile landing performance test now expects fewer than three
/logos/fetches (SSR logo plus at most one post-hydration swap), instead of asserting no Hugging Face logo loads.Reviewed by Cursor Bugbot for commit f850910. Bugbot is set up for automated code reviews on this repo. Configure here.