Skip to content

Remove telemetry#64

Open
rdettai-sk wants to merge 1 commit into
sekoiafrom
remove-telemetry
Open

Remove telemetry#64
rdettai-sk wants to merge 1 commit into
sekoiafrom
remove-telemetry

Conversation

@rdettai-sk

Copy link
Copy Markdown
Collaborator

Description

Remove telemetry just like in upstream.

How was this PR tested?

Describe how you tested this PR.

Copilot AI review requested due to automatic review settings June 12, 2026 18:33

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the quickwit-telemetry crate and all remaining call sites/config/docs that referenced telemetry, aligning the repository with an upstream state that no longer ships telemetry.

Changes:

  • Removed the quickwit-telemetry crate (code + Cargo manifest) and its workspace membership.
  • Removed telemetry event emission from the CLI and UI server, plus CI env vars and user documentation for QW_DISABLE_TELEMETRY.
  • Updated Cargo.lock and third-party license inventory to reflect dependency graph changes.

Reviewed changes

Copilot reviewed 16 out of 17 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
quickwit/quickwit-telemetry/src/sink.rs Deleted telemetry sink + HTTP client implementation.
quickwit/quickwit-telemetry/src/sender.rs Deleted telemetry sender/loop implementation and tests.
quickwit/quickwit-telemetry/src/payload.rs Deleted telemetry payload/event schema.
quickwit/quickwit-telemetry/src/lib.rs Deleted telemetry crate public API (start_telemetry_loop, send_telemetry_event, env key).
quickwit/quickwit-telemetry/Cargo.toml Removed telemetry crate manifest and dependencies.
quickwit/quickwit-serve/src/ui_handler.rs Removed UI index-load telemetry event emission.
quickwit/quickwit-serve/Cargo.toml Dropped quickwit-telemetry dependency.
quickwit/quickwit-cli/src/service.rs Removed telemetry loop setup and run/end command telemetry events.
quickwit/quickwit-cli/src/main.rs Removed telemetry-dependent help/about text.
quickwit/quickwit-cli/Cargo.toml Dropped quickwit-telemetry dependency.
quickwit/Cargo.toml Removed quickwit-telemetry from workspace members/default-members and workspace deps.
quickwit/Cargo.lock Removed telemetry crate and related dependency entries; normalized some dependency specs.
LICENSE-3rdparty.csv Updated third-party inventory entries after dependency changes.
docs/telemetry.md Removed telemetry documentation page.
docs/reference/cli.md Removed QW_DISABLE_TELEMETRY CLI env var reference.
.github/workflows/coverage.yml Removed QW_DISABLE_TELEMETRY from workflow env.
.github/workflows/ci.yml Removed QW_DISABLE_TELEMETRY from workflow env.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread LICENSE-3rdparty.csv
Comment on lines 131 to 133
encode_unicode,https://github.com/tormol/encode_unicode,Apache-2.0 OR MIT,Torbjørn Birch Moltu <t.b.moltu@lyse.net>
encoding_rs,https://github.com/hsivonen/encoding_rs,(Apache-2.0 OR MIT) AND BSD-3-Clause,Henri Sivonen <hsivonen@hsivonen.fi>
enum-iterator,https://github.com/stephaneyfx/enum-iterator,0BSD,Stephane Raux <stephaneyfx@gmail.com>
enum-iterator-derive,https://github.com/stephaneyfx/enum-iterator,0BSD,Stephane Raux <stephaneyfx@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants