Retry more S3 errors#63
Open
rdettai-sk wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR expands Quickwit’s custom AWS retry classifier to treat additional S3 DispatchFailure error kinds as retryable, addressing cases where Smithy classifies transport-level failures with retry-relevant ErrorKinds.
Changes:
- Import
ErrorKindfromaws_config::retryfor use in retry classification. - Extend
SdkError::DispatchFailureretry logic to also retryThrottlingErrorandServerError(in addition toTransientError).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
quickwit-oss#6502 mentions that some other S3 errors might need to be retried. We add them as well even though they seem unlikely to occur.
How was this PR tested?
Describe how you tested this PR.