Skip to content

Changes intended to improve how RenderSorter handles nested group layers #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
spiralhug wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Changes intended to improve how RenderSorter handles nested group layers #312

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions SuperTiled2Unity/Packages/com.seanba.super-tiled2unity/Editor/Importers/RendererSorter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,16 +46,21 @@ public void EndObjectLayer(SuperObjectLayer layer)

public void BeginGroupLayer(SuperGroupLayer layer)
{
CurrentTileZ = 0;
// Do this before m_GroupDepth is incremented to see if I'm in a nested group
// If I am not, reset CurrentTileZ
if (!IsInGroup())
CurrentTileZ = 0;
m_GroupDepth++;
SortingLayerCheck(layer.gameObject);
}

public void EndGroupLayer()
{
m_GroupDepth--;
// Do not iterate m_CurrentSortOrder if in a nested group so layers contine to inherit the sorting order from their parent
if (IsInGroup())
return;
m_CurrentSortOrder++;
CurrentTileZ = 0;
}

public string AssignTilemapSort(TilemapRenderer renderer)
Expand Down Expand Up @@ -119,4 +124,4 @@ private void SortingLayerCheck(GameObject go)
}
}
}
}
}