feat(taxonomy): add property events list on property detail#7
Open
lordspline wants to merge 1 commit into
Open
feat(taxonomy): add property events list on property detail#7lordspline wants to merge 1 commit into
lordspline wants to merge 1 commit into
Conversation
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Property detail pages did not show which event definitions currently use a property, forcing users to infer usage elsewhere or run heavier event queries. This fixes PostHog#26463 by exposing ingestion metadata on the property detail view without a live ClickHouse scan.
Changes
GET /api/projects/{project_id}/property_definitions/{id}/events/with typed serializers,property_definition:readpermissions, limit/offset pagination, and team-scoped Postgres metadata queries.posthog_eventpropertyas the authoritative association source populated asynchronously by ingestion; joins to currentEventDefinitionrows for navigation and event-level last-seen context, so deleted event definitions are omitted and empty means no current event definition is known to use the property.How did you test this code?
hogli test posthog/api/test/test_property_definition.py -k property_definition_events— 7 passed.hogli test frontend/src/scenes/data-management/definition/definitionLogic.test.ts frontend/src/scenes/data-management/definition/DefinitionView.test.tsx— 9 passed.hogli build:openapi -y.pnpm --filter=@posthog/frontend typegen:check -- --files src/scenes/data-management/definition/definitionLogic.ts.pnpm --filter=@posthog/frontend typescript:check.pnpm --filter=@posthog/mcp typecheck.ruff format --check/ruff checkon touched Python files andoxfmt --check/oxlinton touched frontend files.👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Automatic notifications
Docs update
No docs update; this is an in-product Data management detail-page improvement.
🤖 Agent context
Autonomy: Human-driven (agent-assisted)
Captain Capy implemented this end to end. The main design choice was to use ingestion-maintained
posthog_eventpropertymetadata joined with currentEventDefinitionrows, rather than scanning raw event data, because the product need is a current metadata association list with explicit asynchronous freshness semantics. The new endpoint is typed and generated for frontend use; the MCP YAML was synced but left disabled by default.Need help on this PR? Tag
/codesmithwith what you need. Autofix is disabled.