Skip to content

Perf: banners and room icons#851

Merged
nushea merged 8 commits into
devfrom
fix/perfect-banners-and-room-icons
May 16, 2026
Merged

Perf: banners and room icons#851
nushea merged 8 commits into
devfrom
fix/perfect-banners-and-room-icons

Conversation

@nushea
Copy link
Copy Markdown
Member

@nushea nushea commented May 15, 2026

Description

Add settings for rooms icons showing for every space with the default leaving it up to the general setting for icons showing, and the rest overriding it:
image

For the Room currently it will be present inside of the
image

It also adds styling to the RoomCard using the banner in preparation of maybe when it might happen that the associated MSC gets merged into the spec (as it stands it only works with rooms you are already a member of as it is stored as a regular state event)
image

And it also increases the size of the Vertical resizer bar as they are the ones that are possible to be seen on mobile and it helps with gripping them, and separated them into classes better so it might be more easily changeable with a tweak if so desired.
image

Lastly it fixes the banner buttons previously being enabled when the user is missing the permissions to edit the room banner

Fixes #

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

AI disclosure:

  • Partially AI assisted (clarify which code was AI assisted and briefly explain what it does).
  • Fully AI generated (explain what all the generated code does in moderate detail).

Caine (the AI from TADC) gave me swappable parts and trapped me into a circus if that counts as assistance!

@nushea nushea requested review from 7w1 and hazre as code owners May 15, 2026 17:15
@nushea nushea force-pushed the fix/perfect-banners-and-room-icons branch from 4aac6ef to 027f6d2 Compare May 15, 2026 17:16
@nushea nushea force-pushed the fix/perfect-banners-and-room-icons branch from 0b2a4ee to 4a2521c Compare May 15, 2026 21:20
Comment thread src/app/features/common-settings/general/RoomProfile.tsx Outdated
Comment thread src/app/components/room-card/RoomCard.tsx Outdated
@github-actions
Copy link
Copy Markdown
Contributor

Deploying with  Cloudflare Workers  Cloudflare Workers

Status Preview URL Commit Alias Updated (UTC)
✅ Deployment successful! https://pr-851-sable.raspy-dream-bb1d.workers.dev 6c832a8 pr-851 Sat, 16 May 2026 10:32:11 GMT

Copy link
Copy Markdown
Member

@7w1 7w1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nushea nushea added this pull request to the merge queue May 16, 2026
Merged via the queue into dev with commit a8eee71 May 16, 2026
12 checks passed
@nushea nushea deleted the fix/perfect-banners-and-room-icons branch May 16, 2026 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants