Mortgage Calculator v2: stable results card, granular dashing, deferred errors, tax/insurance input fixes#160
Open
jenbreese wants to merge 2 commits into
Open
Mortgage Calculator v2: stable results card, granular dashing, deferred errors, tax/insurance input fixes#160jenbreese wants to merge 2 commits into
jenbreese wants to merge 2 commits into
Conversation
…ed errors, tax/insurance input fixes - Results card is now always visible with its full structure. Removed the all-or-nothing swap to an empty/coral panel that caused the card to disappear and reappear while editing. - Per-line dashing by dependency: a result line shows "-" only when an input it depends on is empty/out-of-range; unaffected lines hold steady. Total dashes iff any component line (mortgage + tax + insurance + HOA) dashes. - Range/limit errors now render as a banner above the card instead of replacing it. - Fixed a render-loop "flicker" when a large tax/insurance dollar amount exceeded the 10%-of-price cap: the home price no longer collapses to 0 on a tax/insurance block (price depends only on payment/rate/term/down-payment), so the cap check is stable. - Field errors now wait until the user leaves the field (focusedField suppression) for the required fields (monthly payment, home price, interest rate), instead of firing mid-edit while backspacing. - Property tax & homeowners insurance inputs are now string-backed (both % and $, both tabs), matching the down-payment pattern: typing 0 shows 0 and the field can be cleared. Financial math is unchanged. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
READY FOR REVIEW
NOT READY FOR REVIEW
Summary
Review By (Date)
Criticality
Review Tasks
Setup tasks and/or behavior to test
Front End Validation
Backend / Functional Validation
Code
Code security
General
Affected Projects or Products
Associated Issues and/or People
@mentionthem here)Resources