Skip to content

Mortgage Calculator v2: stable results card, granular dashing, deferred errors, tax/insurance input fixes#160

Open
jenbreese wants to merge 2 commits into
devfrom
mort-calc-0717
Open

Mortgage Calculator v2: stable results card, granular dashing, deferred errors, tax/insurance input fixes#160
jenbreese wants to merge 2 commits into
devfrom
mort-calc-0717

Conversation

@jenbreese

@jenbreese jenbreese commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator

READY FOR REVIEW

  • Results card is now always visible with its full structure. Removed the all-or-nothing swap to an empty/coral panel that caused the card to disappear and reappear while editing.
  • Per-line dashing by dependency: a result line shows "-" only when an input it depends on is empty/out-of-range; unaffected lines hold steady. Total dashes iff any component line (mortgage + tax + insurance + HOA) dashes.
  • Range/limit errors now render as a banner above the card instead of replacing it.
  • Fixed a render-loop "flicker" when a large tax/insurance dollar amount exceeded the 10%-of-price cap: the home price no longer collapses to 0 on a tax/insurance block (price depends only on payment/rate/term/down-payment), so the cap check is stable.
  • Field errors now wait until the user leaves the field (focusedField suppression) for the required fields (monthly payment, home price, interest rate), instead of firing mid-edit while backspacing.
  • Property tax & homeowners insurance inputs are now string-backed (both % and $, both tabs), matching the down-payment pattern: typing 0 shows 0 and the field can be cleared. Financial math is unchanged.
  • Fixed color to the right teal.
  • Fixed the results panel that had a light green background.
  • Calcula

NOT READY FOR REVIEW

  • (Edit the above to reflect status)

Summary

  • TL;DR - what's this PR for?

Review By (Date)

  • When does this need to be reviewed by?

Criticality

  • How critical is this PR on a 1-10 scale? See Severity Assessment.
  • E.g., it affects one site, or every site and product?

Review Tasks

Setup tasks and/or behavior to test

  1. Check out this branch
  2. Navigate to...
  3. Verify...

Front End Validation

  • Is the markup using the appropriate semantic tags and passes HTML validation?
  • Cross-browser testing has been performed?
  • Automated accessibility scans performed?
  • Manual accessibility tests performed?
  • Design is approved by @ user?

Backend / Functional Validation

Code

  • Are the naming conventions following our standards?
  • Does the code have sufficient inline comments?
  • Is there anything in this code that would be hidden or hard to discover through the UI?
  • Are there any code smells?
  • Are tests provided? eg (unit, behat, or codeception)

Code security

General

  • Is there anything included in this PR that is not related to the problem it is trying to solve?
  • Is the approach to the problem appropriate?

Affected Projects or Products

  • Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

  • JIRA ticket(s)
  • Other PRs
  • Any other contextual information that might be helpful (e.g., description of a bug that this PR fixes, new functionality that it adds, etc.)
  • Anyone who should be notified? (@mention them here)

Resources

jenbreese and others added 2 commits July 17, 2026 09:55
…ed errors, tax/insurance input fixes

- Results card is now always visible with its full structure. Removed the
  all-or-nothing swap to an empty/coral panel that caused the card to
  disappear and reappear while editing.
- Per-line dashing by dependency: a result line shows "-" only when an input
  it depends on is empty/out-of-range; unaffected lines hold steady. Total
  dashes iff any component line (mortgage + tax + insurance + HOA) dashes.
- Range/limit errors now render as a banner above the card instead of
  replacing it.
- Fixed a render-loop "flicker" when a large tax/insurance dollar amount
  exceeded the 10%-of-price cap: the home price no longer collapses to 0 on a
  tax/insurance block (price depends only on payment/rate/term/down-payment),
  so the cap check is stable.
- Field errors now wait until the user leaves the field (focusedField
  suppression) for the required fields (monthly payment, home price, interest
  rate), instead of firing mid-edit while backspacing.
- Property tax & homeowners insurance inputs are now string-backed (both %
  and $, both tabs), matching the down-payment pattern: typing 0 shows 0 and
  the field can be cleared. Financial math is unchanged.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants