Skip to content

Fix VersionChecker logging, timeout, URL and tag-name parsing (#33)#65

Merged
samatstariongroup merged 3 commits into
developmentfrom
GH33
May 31, 2026
Merged

Fix VersionChecker logging, timeout, URL and tag-name parsing (#33)#65
samatstariongroup merged 3 commits into
developmentfrom
GH33

Conversation

@samatstariongroup

Copy link
Copy Markdown
Member

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the EcoreNetto code style guidelines
  • I have provided test coverage for my change (where applicable)

Description

  • Makes the GitHub releases URL and HTTP timeout configurable via optional constructor parameters with sensible defaults (exposed as ReleasesUrl/Timeout); no DI changes needed.
  • Replaces the empty LogError message with a descriptive one that includes the attempted URL; fixes the "GitGub" typo in the timeout warning.
  • Parses the release tag tolerantly (strips a leading 'v' and any SemVer pre-release/build suffix, then Version.TryParse), logging a warning and skipping the comparison on a malformed tag instead of throwing FormatException.

@github-actions

Copy link
Copy Markdown
Contributor
Package Line Rate Branch Rate Complexity Health
ECoreNetto 84% 74% 401
ECoreNetto.Extensions 99% 93% 101
ECoreNetto.HandleBars 99% 98% 60
ECoreNetto.Reporting 83% 70% 181
ECoreNetto.Tools 94% 87% 59
Summary 88% (2105 / 2389) 79% (472 / 596) 802

@sonarqubecloud

Copy link
Copy Markdown

@samatstariongroup samatstariongroup merged commit 0df2611 into development May 31, 2026
14 checks passed
@samatstariongroup samatstariongroup deleted the GH33 branch May 31, 2026 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant