Skip to content

Imported AssnsCrosser algorithm from icarusalg [3/3]#825

Open
PetrilloAtWork wants to merge 1 commit into
SBNSoftware:developfrom
PetrilloAtWork:feature/gp_moveAlgs
Open

Imported AssnsCrosser algorithm from icarusalg [3/3]#825
PetrilloAtWork wants to merge 1 commit into
SBNSoftware:developfrom
PetrilloAtWork:feature/gp_moveAlgs

Conversation

@PetrilloAtWork
Copy link
Copy Markdown
Member

This is a dependent PR of SBNSoftware/sbnalg#2: see that PR for details.

This PR updates header paths and namespaces after the move of code from icarusalg to sbnalg.
Only @SFBayLaser to review this one.

@leoaliaga
Copy link
Copy Markdown
Contributor

trigger build larsoft@v10_06_00 LArSoft/lar*@LARSOFT_SUITE_v10_06_00 SBNSoftware/sbnalg@v10_06_00_01 SBNSoftware/sbncode@v10_06_00_01 SBNSoftware/sbnalg#2

@FNALbuild
Copy link
Copy Markdown
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Copy Markdown
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Copy Markdown
Collaborator

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Copy Markdown
Collaborator

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

Copy link
Copy Markdown
Contributor

@SFBayLaser SFBayLaser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obviously this has to wait until included in sbnalg but I agree this is a good addition and change.

@jas1005
Copy link
Copy Markdown
Contributor

jas1005 commented May 21, 2026

@PetrilloAtWork, I'm unable to get ICARUSAlg PR 94 to build with the latest build command in that PR. The culprit seems to be in this sibling PR for ICARUSCode. From the following segment of the logs for build 14579, I think that the issue is something in the icaruscode/Analysis/trigger/TimeTrackTreeStorageCRT_module.cc file. Can you take a look at this?

5321: [905/2255] Linking CXX shared library sbnanaobj/slf7.x86_64.e26.prof/lib/libsbnanaobj_StandardRecordProxy.so
5322: [906/2255] Building CXX object icarusalg/icarusalg/Geometry/CMakeFiles/icarusalg_Geometry.dir/details/ROPandTPCsetBuildingAlg.cxx.o
5323: [907/2255] Linking CXX shared library sbncode/slf7.x86_64.e26.prof/lib/libsbncode_FluxReader.so
5324: [908/2255] Generating dictionary files for target icaruscode_IcarusObj
5325: [909/2255] Building CXX object icaruscode/icaruscode/Timing/CMakeFiles/icaruscode_Timing_PMTTimingCorrectionService_service.dir/PMTTimingCorrectionService_service.cc.o
5326: [910/2255] Linking CXX shared library icarusalg/slf7.x86_64.e26.prof/lib/libicarusalg_Geometry.so
5327: [911/2255] Linking CXX shared library sbncode/slf7.x86_64.e26.prof/lib/libsbncode_FluxReader_FluxReader_source.so
5328: [912/2255] Linking CXX shared library sbncode/slf7.x86_64.e26.prof/lib/libsbncode_FluxReader_FluxReaderAna_module.so
5329: [913/2255] Building CXX object icaruscode/icaruscode/Analysis/trigger/CMakeFiles/icaruscode_Analysis_trigger_TimeTrackTreeStorageCRT_module.dir/TimeTrackTreeStorageCRT_module.cc.o
5330: FAILED: icaruscode/icaruscode/Analysis/trigger/CMakeFiles/icaruscode_Analysis_trigger_TimeTrackTreeStorageCRT_module.dir/TimeTrackTreeStorageCRT_module.cc.o

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants