chore: [DevOps] Fix parsing of multiline strings in E2E test workflow#944
Open
Jonas-Isr wants to merge 8 commits into
Open
chore: [DevOps] Fix parsing of multiline strings in E2E test workflow#944Jonas-Isr wants to merge 8 commits into
Jonas-Isr wants to merge 8 commits into
Conversation
| echo "error_message=$ERROR_MSG" >> $GITHUB_OUTPUT | ||
| echo "error_message<<GITHUB_OUTPUT_EOF" >> $GITHUB_OUTPUT | ||
| echo "$ERROR_MSG" >> $GITHUB_OUTPUT | ||
| echo "GITHUB_OUTPUT_EOF" >> $GITHUB_OUTPUT |
Contributor
There was a problem hiding this comment.
What purpose does putting message<<EOF in the output have
Member
Author
There was a problem hiding this comment.
It's documented here.
Basically, the first line tells github to treat everything that comes next until GITHUB_OUTPUT_EOF as input to $GITHUB_OUTPUT. Then in the third line we actually add GITHUB_OUTPUT_EOF manually to signal that the input is over. The only caveat is that you have to make sure that GITHUB_OUTPUT_EOF does not appear in $ERROR_MSG (which I think is pretty unlikely to happen).
Contributor
There was a problem hiding this comment.
Why do we need to do that? What made it fail?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Recently the E2E test workflow always failed with message:
This PR fixes the parsing error.
Test run without parsing error here.