Skip to content

fix: migrate to to_string_with_radix #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DanielleHuisman merged 3 commits into from
Jun 23, 2026
Merged

fix: migrate to to_string_with_radix #102

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0c786d7
chore(deps): update prettier to v3.8.4 (#99)
renovate[bot] Jun 22, 2026
085bb7d
chore(deps): update rust crate regex to v1.12.4 (#100)
renovate[bot] Jun 22, 2026
14c4e5d
fix: migrate to `to_string_with_radix`
DanielleHuisman Jun 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions packages/pretty-format/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
if Object::is(val, &JsValue::from_f64(-0.0)) {
"-0".to_owned()
} else {
val.to_string(10)
val.to_string_with_radix(10)

Check failure on line 18 in packages/pretty-format/src/lib.rs

View workflow job for this annotation

GitHub Actions / Rust / Test 

no method named `to_string_with_radix` found for reference `&Number` in the current scope

Check failure on line 18 in packages/pretty-format/src/lib.rs

View workflow job for this annotation

GitHub Actions / Rust / Lint 

no method named `to_string_with_radix` found for reference `&web_sys::js_sys::Number` in the current scope
.expect("Number should be formatted as string.")
.into()
}
Expand All @@ -25,7 +25,7 @@
format!(
"{}n",
String::from(
val.to_string(10)
val.to_string_with_radix(10)

Check failure on line 28 in packages/pretty-format/src/lib.rs

View workflow job for this annotation

GitHub Actions / Rust / Test 

no method named `to_string_with_radix` found for reference `&BigInt` in the current scope

Check failure on line 28 in packages/pretty-format/src/lib.rs

View workflow job for this annotation

GitHub Actions / Rust / Lint 

no method named `to_string_with_radix` found for reference `&web_sys::js_sys::BigInt` in the current scope
.expect("Number should be formatted as string.")
)
)
Expand Down
Loading