builder: allow unsigned integers in neg and exactsdiv.#562
Draft
builder: allow unsigned integers in neg and exactsdiv.#562
neg and exactsdiv.#562Conversation
Firestar99
force-pushed
the
eddyb/unsigned-neg-exactsdiv
branch
from
7ff8561 to
af8bf6f
Compare
Firestar99
reviewed
Apr 14, 2026
Comment on lines
+1
to
+23
| error: unsupported unsized `[struct () { }]` constant | ||
| | | ||
| = note: used by unnamed global (%68) | ||
| = note: used by unnamed global (%69) | ||
| note: used from within `size_of_val_unsized::main` | ||
| --> <$DIR/size_of_val_unsized.rs>:5:12 | ||
| | | ||
| LL | *out = core::mem::size_of_val( | ||
| | ____________^ | ||
| LL | | const { | ||
| LL | | struct S<T: ?Sized>(T); | ||
| LL | | &S([]) as &S<[()]> | ||
| LL | | }, | ||
| LL | | ); | ||
| | |_____^ | ||
| note: called by `main` | ||
| --> <$DIR/size_of_val_unsized.rs>:4:8 | ||
| | | ||
| LL | pub fn main(out: &mut usize) { | ||
| | ^^^^ | ||
|
|
||
| error: aborting due to 1 previous error | ||
|
|
Member
There was a problem hiding this comment.
I think the patch is fine, saw the todo, moved it to a compiletest and it resulted in this interesting error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rustc_codegen_ssarelies on signed operations on unsigned integers for e.g.size_of_val.TODO: move this from the compute shader (see diff) to a proper test: