Skip to content

feat!: Add keyboard shortcut to toggle screenreader mode#9869

Merged
gonfunko merged 7 commits into
v13from
screenreader-mode
May 14, 2026
Merged

feat!: Add keyboard shortcut to toggle screenreader mode#9869
gonfunko merged 7 commits into
v13from
screenreader-mode

Conversation

@gonfunko
Copy link
Copy Markdown
Contributor

The basics

The details

Resolves

Fixes #9861

Proposed Changes

This PR adds a keyboard shortcut bound to Command Option Z that toggles screenreader mode on or off. With screenreader mode on, navigation looping is disabled and navigating between blocks of different nesting levels plays tones whose frequency corresponds to the level of nesting.

Additionally, error boops are now played when reaching the end of navigation, regardless of whether screenreader mode is on or off.

@gonfunko gonfunko requested a review from a team as a code owner May 13, 2026 21:00
@gonfunko gonfunko requested a review from mikeharv May 13, 2026 21:00
@github-actions github-actions Bot added breaking change Used to mark a PR or issue that changes our public APIs. PR: feature Adds a feature labels May 13, 2026
Copy link
Copy Markdown
Contributor

@mikeharv mikeharv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good. My naming comment is a bit nit-picky, but I mention it because now is the easiest time to get it right. Open to your thoughts!

Let me know what you think about adding a toast as well.

Comment thread packages/blockly/core/keyboard_navigation_controller.ts Outdated
Comment thread packages/blockly/core/shortcut_items.ts
@gonfunko gonfunko requested a review from mikeharv May 14, 2026 16:17
"DELETE_X_BLOCKS": "context menu - Permanently delete the %1 selected blocks.\n\nParameters:\n* %1 - an integer greater than 1.",
"DELETE_ALL_BLOCKS": "confirmation prompt - Question the user if they really wanted to permanently delete all %1 blocks.\n\nParameters:\n* %1 - an integer greater than 1.",
"CLEAN_UP": "context menu - Reposition all the blocks so that they form a neat line.",
"CLOSE": "toast notification - Accessibility label for close button.",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-add?

@gonfunko gonfunko merged commit 799965f into v13 May 14, 2026
5 checks passed
@gonfunko gonfunko deleted the screenreader-mode branch May 14, 2026 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change Used to mark a PR or issue that changes our public APIs. PR: feature Adds a feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants