Skip to content

Adapt custom overlay to QUIC transport#195

Open
bvscd wants to merge 1 commit into
masterfrom
custom_overlay
Open

Adapt custom overlay to QUIC transport#195
bvscd wants to merge 1 commit into
masterfrom
custom_overlay

Conversation

@bvscd
Copy link
Copy Markdown
Collaborator

@bvscd bvscd commented May 28, 2026

No description provided.

Copilot AI review requested due to automatic review settings May 28, 2026 22:33
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds opt-in QUIC two-step broadcast support for custom overlays via a new use_quic field in the TL/JSON config, refactors CustomOverlayClient to share the full NetworkStack and route sends through broadcast_twostep, and extends custom overlays to handle V2 block/candidate compressed broadcasts. The PR also bundles several unrelated changes (RLDP diagnostics, simplex finalized-callback dedup idempotency fix, SUPPORTED_VERSION bump to 14, ADNL addr_list.reinit_date sync, test harness cleanups).

Changes:

  • Custom overlay config gains use_quic:Bool (TL + JSON parse/save) and CustomOverlayClient passes it into OverlayNode::add_private_overlay and broadcast_twostep.
  • NodeNetwork registers the default overlay ADNL key with QUIC at startup and extracts shared compute_quic_bind_addr / bind_quic_key helpers; BroadcastSendMethod::QuicOrRldp now actually falls back to RLDP instead of silently no-op'ing.
  • Independent fixes: V2 candidate/block broadcast processing in custom overlays, simplex finalized-callback dedup is now idempotent for the same block_id across slot-keyed cleanup, RLDP receive diagnostics, SUPPORTED_VERSION = 14.

Reviewed changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/tl/ton_api/tl/ton_api.tl Adds use_quic:Bool to engine.validator.customOverlay.
src/node/src/config.rs Parses optional use_quic (default false) and persists it for every overlay.
src/node/src/tests/test_config.rs Serde round-trip test seeds random use_quic.
src/node/src/network/custom_overlay_client.rs Holds NetworkStack, plumbs use_quic, switches send path to broadcast_twostep, adds V2 block/candidate handling.
src/node/src/network/full_node_overlays.rs Updates call sites to the new send_broadcast(data, flags) signature and passes shared stack.
src/node/src/network/node_network.rs Adds startup QUIC binding for default overlay key and extracts compute_quic_bind_addr / bind_quic_key.
src/node/src/network/mod.rs Adds decompress_and_check_candidate_data_v2 and exports new V2 broadcast type.
src/adnl/src/overlay/mod.rs QuicOrRldp now properly falls back to RLDP rather than returning no-op None.
src/adnl/src/adnl/node.rs Syncs outgoing addr_list.reinit_date to packet reinit_date.
src/adnl/src/rldp/mod.rs Adds per-transfer packet/confirmation counters and per-chunk debug logging; error log includes source peer.
src/adnl/src/rldp/recv.rs send_confirmations returns the number of confirmation packets sent.
src/node/simplex/src/session_processor.rs finalized_delivery_sent_seqno now stores FinalizedSeqnoRecord; same-block re-entry is idempotent.
src/node/simplex/src/tests/test_session_processor.rs Adds regression tests for seqno dedup retention and idempotent re-entry.
src/block/src/config_params.rs Bumps SUPPORTED_VERSION from 13 → 14.
src/node/tests/test_run_net_py/run_singlehost_nodectl.py Removes elections.cache_refresh_secs patch and per-node ton-http-api failover endpoints; drops sleep after tick_interval patch.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Base automatically changed from release/node/v0.8.1 to master May 29, 2026 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants