Adapt custom overlay to QUIC transport#195
Open
bvscd wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds opt-in QUIC two-step broadcast support for custom overlays via a new use_quic field in the TL/JSON config, refactors CustomOverlayClient to share the full NetworkStack and route sends through broadcast_twostep, and extends custom overlays to handle V2 block/candidate compressed broadcasts. The PR also bundles several unrelated changes (RLDP diagnostics, simplex finalized-callback dedup idempotency fix, SUPPORTED_VERSION bump to 14, ADNL addr_list.reinit_date sync, test harness cleanups).
Changes:
- Custom overlay config gains
use_quic:Bool(TL + JSON parse/save) andCustomOverlayClientpasses it intoOverlayNode::add_private_overlayandbroadcast_twostep. NodeNetworkregisters the default overlay ADNL key with QUIC at startup and extracts sharedcompute_quic_bind_addr/bind_quic_keyhelpers;BroadcastSendMethod::QuicOrRldpnow actually falls back to RLDP instead of silently no-op'ing.- Independent fixes: V2 candidate/block broadcast processing in custom overlays, simplex finalized-callback dedup is now idempotent for the same
block_idacross slot-keyed cleanup, RLDP receive diagnostics,SUPPORTED_VERSION = 14.
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/tl/ton_api/tl/ton_api.tl | Adds use_quic:Bool to engine.validator.customOverlay. |
| src/node/src/config.rs | Parses optional use_quic (default false) and persists it for every overlay. |
| src/node/src/tests/test_config.rs | Serde round-trip test seeds random use_quic. |
| src/node/src/network/custom_overlay_client.rs | Holds NetworkStack, plumbs use_quic, switches send path to broadcast_twostep, adds V2 block/candidate handling. |
| src/node/src/network/full_node_overlays.rs | Updates call sites to the new send_broadcast(data, flags) signature and passes shared stack. |
| src/node/src/network/node_network.rs | Adds startup QUIC binding for default overlay key and extracts compute_quic_bind_addr / bind_quic_key. |
| src/node/src/network/mod.rs | Adds decompress_and_check_candidate_data_v2 and exports new V2 broadcast type. |
| src/adnl/src/overlay/mod.rs | QuicOrRldp now properly falls back to RLDP rather than returning no-op None. |
| src/adnl/src/adnl/node.rs | Syncs outgoing addr_list.reinit_date to packet reinit_date. |
| src/adnl/src/rldp/mod.rs | Adds per-transfer packet/confirmation counters and per-chunk debug logging; error log includes source peer. |
| src/adnl/src/rldp/recv.rs | send_confirmations returns the number of confirmation packets sent. |
| src/node/simplex/src/session_processor.rs | finalized_delivery_sent_seqno now stores FinalizedSeqnoRecord; same-block re-entry is idempotent. |
| src/node/simplex/src/tests/test_session_processor.rs | Adds regression tests for seqno dedup retention and idempotent re-entry. |
| src/block/src/config_params.rs | Bumps SUPPORTED_VERSION from 13 → 14. |
| src/node/tests/test_run_net_py/run_singlehost_nodectl.py | Removes elections.cache_refresh_secs patch and per-node ton-http-api failover endpoints; drops sleep after tick_interval patch. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.