NOT TO BE MERGED: Python script to benchmark mxr files - consumes mxr files with json encoding#4983
Draft
ahsan-ca wants to merge 1 commit into
Draft
NOT TO BE MERGED: Python script to benchmark mxr files - consumes mxr files with json encoding#4983ahsan-ca wants to merge 1 commit into
ahsan-ca wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new developer utility script under tools/ intended to benchmark GPU-dumped .mxr artifacts and produce a problem_cache.json consumable via MIGRAPHX_PROBLEM_CACHE.
Changes:
- Introduces
tools/benchmark_mxr.pyto load.mxrfiles, run warmup/benchmark iterations, and emit a consolidated problem cache JSON.
Comment on lines
+1
to
+10
| #!/usr/bin/env python3 | ||
| """Benchmark dumped MIGraphX .mxr files and emit a problem cache. | ||
|
|
||
| .mxr files dumped via MIGRAPHX_GPU_DUMP_BENCHMARK_MXR. | ||
|
|
||
| After problem_cache.json file is generated by this script, | ||
| use MIGRAPHX_PROBLEM_CACHE=problem_cache.json to consume it. | ||
|
|
||
| Usage: benchmark_mxr.py <mxr_dir> | ||
| """ |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## benchmark-mxr-format-change #4983 +/- ##
============================================================
Coverage 92.73% 92.73%
============================================================
Files 594 594
Lines 31340 31340
============================================================
Hits 29063 29063
Misses 2277 2277 🚀 New features to boost your workflow:
|
Regressions detected 🔴 |
|
ahsan-ca
force-pushed
the
benchmark-script-python
branch
from
31e77e7 to
b84b23a
Compare
ahsan-ca
force-pushed
the
benchmark-script-python
branch
from
b84b23a to
91fd4b3
Compare
Comment on lines
+1
to
+10
| #!/usr/bin/env python3 | ||
| """Benchmark dumped MIGraphX .mxr files and emit a problem cache. | ||
|
|
||
| .mxr files dumped via MIGRAPHX_GPU_DUMP_BENCHMARK_MXR. | ||
|
|
||
| After problem_cache.json file is generated by this script, | ||
| use MIGRAPHX_PROBLEM_CACHE=problem_cache.json to consume it. | ||
|
|
||
| Usage: benchmark_mxr.py <mxr_dir> | ||
| """ |
Comment on lines
+23
to
+25
| text = next(i.op().values()["text"] for i in p.get_main_module() | ||
| if i.name() == "@comment") | ||
| meta = dict(json.loads(text)) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
For REVIEW purposes only.
Technical Details
Changelog Category
Add a
CHANGELOG.mdentry for any option other thanNot Applicable