Encode benchmark MXR comment metadata as JSON#4982
Open
ahsan-ca wants to merge 3 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the GPU benchmarking MXR dump path to emit a structured (JSON) builtin::comment payload, with the goal of making downstream parsing for benchmarking easier and more robust.
Changes:
- Add
migraphx/json.hppusage incompile_ops.cpp. - Replace the benchmark MXR comment string from ad-hoc text formatting to JSON serialization of
{op, problem, solution}metadata.
pfultz2
approved these changes
Jun 17, 2026
shivadbhavsar
approved these changes
Jun 17, 2026
ahsan-ca
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Using json encoding for comment metadata simplifies parsing
of dumped mxr files for benchmarking later.
Technical Details
Changelog Category
Add a
CHANGELOG.mdentry for any option other thanNot Applicable