[Docs] Add precision support reference page#4965
Conversation
|
Thank you for your contribution! Since this is an external pull request, a maintainer must review PR and add the "ok-to-test" label if it is approved for testing. |
| tag: "migraphx" | ||
| data_types: | ||
| - type: "int8" | ||
| support: "⚠️" |
There was a problem hiding this comment.
What is causing the "partial support" for int8 ?
There was a problem hiding this comment.
This is something that was taken from https://rocm.docs.amd.com/en/latest/reference/precision-support.html?model=migraphx that was approved when it was made - is it not right? int8 is listed in shape.hpp; should it be full support instead?
| @@ -0,0 +1,23 @@ | |||
| name: "MIGraphX" | |||
There was a problem hiding this comment.
What exactly do we mean by:
while also reducing the maintenance of burden of having to manually update the YAML data file in https://rocm.docs.amd.com/en/latest/reference/precision-support.html
It looks like the MIGraphX team needs to manually update this yaml file?
There was a problem hiding this comment.
This PR aims to bring that yaml file over to this repo, so you just need to update it here. In the future, that page on the ROCm docs will automatically pull the yaml files from various repos, so there won't be a need to manually update it in the ROCm repo anymore.
| name: "MIGraphX" | ||
| tag: "migraphx" | ||
| data_types: | ||
| - type: "int8" |
There was a problem hiding this comment.
Missing that we support the OCP MXFP4 (E2M1) datatype.
There was a problem hiding this comment.
And to clarify, int8 should be changed to "full support"?
Motivation
The goal of this PR is to standardize the precision support reference page format across all components, while also reducing the maintenance of burden of having to manually update the YAML data file in https://rocm.docs.amd.com/en/latest/reference/precision-support.html
Technical Details
Changelog Category
Add a
CHANGELOG.mdentry for any option other thanNot Applicable