Fix: careful with linenumber removal in order to improve code coverage#281
Fix: careful with linenumber removal in order to improve code coverage#281lkdvos wants to merge 1 commit into
Conversation
|
Your PR no longer requires formatting changes. Thank you for your contribution! |
| for p in parser.postprocessors | ||
| ex = p(ex)::Expr | ||
| end | ||
| ex = removeinternallinenumbernodes(ex)::Expr |
There was a problem hiding this comment.
Not sure why this is not just added to the list of postprocessors?
There was a problem hiding this comment.
The main reason is that @planar adds some more postprocessors, and this guarantees that this processor is ran at the end, and not before that.
|
Other than my comment, I think this looks reasonable. I indeed removed line numbers to make the macroexpanded code more readable. |
|
If the line number removal is just for the macro-expanded code, it might be reasonable to just disable it altogether? That also avoids the issues with Note that I still need to check that this actually fixes the codecov issue, so this PR is not ready |
2 participants
This is a claude-aided attempt of resolving #280.
From what I could tell, the removal of the line numbers is what causes the codecov gaps.
@Jutho I'm not entirely sure if we really need these to begin with, or if this is just a cosmetic thing to make the generated expressions easier to inspect?
In any case, I still have to more carefully investigate if this actually resolves the issue, and additionally if this automatically carries over to
@planarand@plansor.