chore: auto-update QPK_PIN and pin manifests#250
Conversation
🤖 Codex PR Review🚫 Merge blocked: active blocking history requires independent source-of-truth clearance ⚖️ Codex Review Arbitration🚫 block: Trusted blocking history remains active because the cumulative PR diff does not demonstrably fix the prior packaging defect. In the current diff, Review by Codex PR Review bot • PR |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 31d353a91a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| src/quant_platform_kit/strategy_lifecycle/audit_log.py | ||
| src/quant_platform_kit/strategy_lifecycle/backtest_orchestrator.py | ||
| src/quant_platform_kit/strategy_lifecycle/backtest_scheduler.py | ||
| src/quant_platform_kit/strategy_lifecycle/capabilities.py |
There was a problem hiding this comment.
Keep generated egg-info out of pin-only updates
In the context where this auto-update is merged to main, this non-pin file change means the push is no longer covered by .github/workflows/update-qpk-pin.yml's paths-ignore list, which only ignores QPK_PIN, qsl-pins.txt, constraints.txt, docs, and Markdown files. That will fire the same pin workflow again and create another pin PR for the pin commit itself instead of stopping at the advertised feature SHA f3e719e; it can also cause duplicate downstream pin-sync PRs. Either drop the regenerated SOURCES.txt change from this pin-only commit or update the generated metadata in the feature commit being pinned.
Useful? React with 👍 / 👎.
| us-equity-strategies @ git+https://github.com/QuantStrategyLab/UsEquityStrategies.git@604842139331316f55486cfe33f316bf3e9698e5 | ||
| hk-equity-strategies @ git+https://github.com/QuantStrategyLab/HkEquityStrategies.git@45ab0dce847f8f728c68e9c67d15b661bb6eb80d |
There was a problem hiding this comment.
Align strategy repo pins before publishing constraints
When consumers use this manifest as pip constraints, line 5 constrains QPK to f3e719e while the newly pinned strategy commits still declare their own dependency on QPK 651c9ac in their pyproject.toml metadata (checked UsEquityStrategies@604842, HkEquityStrategies@45ab0d, CnEquityStrategies@a16978, and CryptoStrategies@2aac3a). python -m pip install --help defines -c as “Constrain versions using the given constraints file”, so installing any of these strategy packages under constraints.txt will ask the resolver for two different direct URLs for quant-platform-kit and fail until those downstream commits are repinned first.
Useful? React with 👍 / 👎.
31d353a to
f3087ac
Compare
f3087ac to
0cf083b
Compare
Automated update of QPK_PIN and QSL Git SHA pin manifests.
Compatibility checks passed ✅ — all downstream-critical QPK modules verified importable.
Updated SHAs:
a06a99f74566ce60ae91fc39317cdfc16558e325🤖 Generated with Claude Code