-
Notifications
You must be signed in to change notification settings - Fork 0
docs: make public GCS examples portable #334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+44
−5
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| from pathlib import Path | ||
| import re | ||
| from urllib.parse import urlparse | ||
|
|
||
|
|
||
| REPOSITORY_ROOT = Path(__file__).resolve().parents[1] | ||
| PUBLIC_CONFIG_FILES = ( | ||
| REPOSITORY_ROOT / ".env.example", | ||
| REPOSITORY_ROOT / "docs" / "hk_equity_runtime.md", | ||
|
Pigbibi marked this conversation as resolved.
|
||
| ) | ||
|
|
||
|
|
||
| def test_public_gcs_examples_use_portable_bucket_placeholders(): | ||
| observed = 0 | ||
|
|
||
| for path in PUBLIC_CONFIG_FILES: | ||
| for line_number, line in enumerate( | ||
| path.read_text(encoding="utf-8").splitlines(), start=1 | ||
| ): | ||
| for uri in re.findall(r"gs://[^\s`\"']+", line): | ||
| parsed = urlparse(uri.rstrip("\\")) | ||
| observed += 1 | ||
|
|
||
| assert parsed.scheme == "gs" | ||
| assert parsed.path not in {"", "/"} | ||
| assert parsed.netloc == "your-bucket" or ( | ||
| parsed.netloc.startswith("<") and parsed.netloc.endswith(">") | ||
| ), f"{path.name}:{line_number} uses a deployment-specific GCS bucket" | ||
|
|
||
| assert observed == 6 | ||
|
|
||
|
|
||
| def test_snapshot_publish_prerequisites_cover_writer_and_runtime_reader(): | ||
| runtime_doc = ( | ||
| REPOSITORY_ROOT / "docs" / "hk_equity_runtime.md" | ||
| ).read_text(encoding="utf-8") | ||
|
|
||
| assert "publisher/deploy service account 对自定义目标 bucket 具备所需对象写权限" in runtime_doc | ||
| assert "runtime service account 具备读取权限" in runtime_doc | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.