Fix Cloud Run warmup health route#343
Merged
Merged
Conversation
Co-Authored-By: Codex <noreply@openai.com>
🤖 Codex PR Review✅ Merge allowed: No issues found Review by Codex PR Review bot • PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/healthGET route for Cloud Scheduler warmups/healthzin the workflow contract testProduction evidence
After #342 deployed, authenticated Scheduler calls to
/healthzreturned HTTP 404 and did not reach the Cloud Run revision request logs. The same Scheduler identity/job configuration reached/monitor-dispatch, and switching the warmup target to the existing/healthalias returned success.The live warmup jobs were corrected to
/health; manual non-trading runs for the previously failing u166 service and combo shadow service completed successfully. No/runjob was triggered or given retries.Validation
uv run ruff check .: passedactionlint: passedgit diff --check: passed