ci: clean the zizmor scan (persist-credentials + dependabot cooldown)#70
Merged
Conversation
The advisory zizmor lane flagged 16 artipacked findings (every actions/checkout persists the token in .git/config) and one dependabot-cooldown. No workflow does an authenticated git op (image push is docker-login, releases use the token via gh; release.yml's git archive is read-only), so persist-credentials: false is safe on every checkout - submodule fetch is unaffected (the input only controls what's left in .git/config after checkout, not the checkout-time token). Added a 7-day dependabot cooldown so a freshly-compromised action version stays out of the weekly auto-bump window. zizmor now reports zero findings (exit 0); a new fleet-wide guard in verify-ci-supplychain-unit.bats keeps every checkout opted out (the required lane backstops the advisory zizmor lane).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The advisory zizmor lane (added in #64) has been failing on pre-existing findings. This resolves them so the scan is clean.
artipacked (16 findings) —
persist-credentials: falseEvery
actions/checkoutpersists the GitHub token in.git/configby default, where a later step could read or leak it. No workflow does an authenticated git operation — image publishing is docker-login + cosign OIDC, releases use the token viagh/API, andrelease.yml'sgit archiveis read-only — sopersist-credentials: falseis safe on all 16 checkouts. Submodule fetch is unaffected: the input only controls what's left in.git/configafter checkout, not the token used during it.dependabot-cooldown (1 finding) — 7-day cooldown
Added
cooldown: { default-days: 7 }todependabot.yml. A compromised action release is usually yanked within days, so waiting a week keeps a poisoned bump out of the weekly auto-PR window — a natural fit for this repo's pin-and-bump supply-chain posture.Result
zizmor .github/(online, as CI runs it) now reports "No findings to report", exit 0.actionlint(make lint-ci) still clean.Regression guard
The zizmor lane is advisory (
continue-on-error), so a future checkout could silently reintroduce artipacked without failing a required check. Added a guard toverify-ci-supplychain-unit.bats(the required unit lane): everyactions/checkoutmust have a matchingpersist-credentials: false. Full unit lane green (304).The 20 remaining zizmor items are suppressed (informational / low-confidence), unchanged.