fix: don't leak aux coords of summed dims onto the term dimension#829
Open
FBumann wants to merge 2 commits into
Open
fix: don't leak aux coords of summed dims onto the term dimension#829FBumann wants to merge 2 commits into
FBumann wants to merge 2 commits into
Conversation
Merging this PR will not alter performance
Comparing Footnotes
|
LinearExpression._sum dropped a summed dim's index coords via reset_index but let auxiliary coords defined on that dim ride the stack onto _term, breaking later arithmetic with CoordinateValidationError (#295). Drop them before stacking; aux coords on remaining dims still propagate. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
4aaf556 to
e610c04
Compare
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the remaining alignment-leak half of #295.
Note
The following content was generated by AI.
Changes proposed in this Pull Request
LinearExpression._sumdrops a summed dimension's index coordinates viareset_index, but an auxiliary (non-dimension) coordinate on that dimension — e.g. aB(A)group label — rode the.stack()onto the internal_termhelper dimension. The leaked coordinate then broke later arithmetic:Aux coords whose dims intersect the summed dims are now dropped before stacking. Aux coords on the remaining dimensions still propagate unchanged.
QuadraticExpression.sumand the groupby fallback route through the same_sumand are covered by the same change.Only the leak is fixed here — it is a plain bug under both semantics. The other half of #295's residual (a conflicting aux coord being silently kept in binary operations) is a semantics change and stays with the v1 work (convention §11).
Checklist
AGENTS.md).doc/release_notes.rstof the upcoming release is included.