fix: don't prefix rlm harness metrics with rlm_#1909
Open
mikasenghaas wants to merge 1 commit into
Open
Conversation
The rlm harness `rlm` metric surfaced rlm's session metrics under an `rlm_` prefix (`rlm_turns`, `rlm_prompt_tokens`, ...). Drop the prefix so the metrics are recorded under their own names (`turns`, `prompt_tokens`, ...). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
ApprovabilityVerdict: Needs human review This change modifies the naming convention for RLM harness metrics, removing the 'rlm_' prefix. While small, this is a runtime behavior change that could affect downstream metric consumers (dashboards, monitoring, alerts) expecting the prefixed names. You can customize Macroscope's approvability policy. Learn more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rlm@metricscraped rlm's sessionmeta.jsonand recorded each numeric metric under anrlm_prefix (rlm_turns,rlm_prompt_tokens,rlm_completion_tokens,rlm_compactions_count, ...).turns,prompt_tokens,completion_tokens,compactions_count, ...). Non-numeric fields (e.g.stop_reason) are still skipped.Breaking
RLMHarnesslose theirrlm_prefix. Anything consuming these (dashboards, filters, downstream analysis) must migraterlm_<name>→<name>(e.g.rlm_turns→turns).Note
Medium Risk
Breaking change to metric key names for v1 RLM harness rollouts; consumers must update from
rlm_<name>to<name>.Overview
Breaking: The v1
RLMHarnessrlm@metricno longer prefixes numeric fields from sessionmeta.jsonwithrlm_. Keys such asturns,prompt_tokens, andcompactions_countare recorded under their original names instead ofrlm_turns,rlm_prompt_tokens, etc.Non-numeric metrics (e.g.
stop_reason) are still omitted. Downstream dashboards, filters, or analysis that keyed onrlm_*names need to migrate to the unprefixed keys.Reviewed by Cursor Bugbot for commit b7a7435. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Remove
rlm_prefix from RLM harness metric keysThe
RLMHarness.rlmmethod in harness.py was prefixing each metric key withrlm_before returning. It now returns the original key names frommeta['metrics']unchanged.📊 Macroscope summarized b7a7435. 1 file reviewed, 0 issues evaluated, 0 issues filtered, 0 comments posted
🗂️ Filtered Issues
No issues evaluated.