sandbox allowed/blocked domains#712
Open
kcoopermiller wants to merge 5 commits into
Open
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit c583d27. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Note
Medium Risk
Changes sandbox network egress configuration surface; misconfiguration could weaken isolation, though enforcement depends on the backend and VM sandboxes are blocked client-side.
Overview
Adds sandbox egress domain controls end-to-end in the SDK and
primeCLI:allowed_domains(allowlist when network is off) andblocked_domains(blocklist when network is on), including wildcard support in CLI help.prime-sandboxes exposes the fields on
SandboxandCreateSandboxRequest, with validators tying allowlists tonetwork_access=false, blocklists tonetwork_access=true, and rejecting both on VM sandboxes.CLI adds repeatable
--allowed-domain/--blocked-domainonsandbox create, mirrors the same rules before submit, shows domains on create summary andsandbox get, and errors if an olderprime-sandboxeswheel lacks the fields when those flags are used.Tests cover forwarding lists into
CreateSandboxRequestand the SDK-missing-field guard.Reviewed by Cursor Bugbot for commit b5f1018. Bugbot is set up for automated code reviews on this repo. Configure here.