Fix SSPI acceptor credentials#857
Open
elric1 wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes the Windows SSPI GSSAPI shim’s handling of GSS_C_NO_CREDENTIAL in gss_accept_sec_context() so that, when GSSAPIStrictAcceptorCheck is disabled, the server can accept contexts using the default inbound acceptor credentials instead of dereferencing a null credential handle.
Changes:
- Detect
acceptor_cred_handle == GSS_C_NO_CREDENTIALand obtain a default inbound SSPI credential handle. - Use the selected credential handle (
defaultvssupplied) when callingAcceptSecurityContext().
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Author
|
@microsoft-github-policy-service agree company="The Old Chapel Technology, Ltd" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Fix the Windows SSPI shim when GSSAPIStrictAcceptorCheck is disabled.
PR Context
In that mode sshd passes GSS_C_NO_CREDENTIAL to gss_accept_sec_context(), which should mean "use the default acceptor credential"; the shim instead dereferenced it as a real credential handle.