Fix results ordering, control file whitespace, ENABLE_* overrides#19
Open
jnasbyupgrade wants to merge 2 commits into
Open
Fix results ordering, control file whitespace, ENABLE_* overrides#19jnasbyupgrade wants to merge 2 commits into
jnasbyupgrade wants to merge 2 commits into
Conversation
…ce, overrides) Add tests/updates for pgxntool commit 20c2552: - Fix `results:` ordering: `verify-results` now runs after `test` (not before) - Fix `parse_control_file` trailing whitespace stripping (multiple spaces/tabs) - Add `override` to `PGXNTOOL_ENABLE_*` so command-line values are normalized - `make-results.bats`: new test verifying `verify-results` blocks `make results` when tests are failing; updated comments - `test-verify-results.bats`: remove `make results` assertion (now requires PostgreSQL since `make results` runs `make test` first); add clarifying comments - New `04-pgtle.bats` test: `pgtle.sh` handles multiple spaces and tab before trailing comment in control files - `template-multi-extension/ext_beta.control`: use multiple spaces before trailing comment to exercise whitespace trimming - `multi-extension.bats`: update comments for multiple-spaces testing - `test.md` agent: fix debug level description (BATS 1–5 scale vs `lib.sh` 10–50) - `gather-repo-info.sh`: add sanity check for invalid debug levels Co-Authored-By: Claude <noreply@anthropic.com>
jnasbyupgrade
changed the title
Updates for pgxntool commit 6e707bb (clarify debug() level scheme): - `lib.sh` comment updated to range-based scheme (1-9, 10-19, 20-29...) `test/lib/helpers.bash`: `debug()` now checks `$TESTDEBUG` instead of `$DEBUG`, so test infrastructure verbosity and pgxntool script verbosity are independently controlled. Use `TESTDEBUG=N` for test runs, `DEBUG=N` for pgxntool scripts. `.claude/skills/commit/SKILL.md`: Added Step 2b — advisory scan of debug level distribution in changed pgxntool `.sh` files at commit time. Flags scripts with loops but only single-digit levels, or 5+ calls all at the same level. `.claude/agents/test.md`, `.claude/settings.json`: Updated all `DEBUG=` references to `TESTDEBUG=`; corrected stale debug level descriptions to match helpers.bash. `.claude/skills/test/scripts/run-tests.sh`: Derive `PGPORT` from `PGCLUSTER` at startup so pg_regress and raw PostgreSQL binaries use the correct cluster port. Co-Authored-By: Claude <noreply@anthropic.com>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related pgxntool PR: Postgres-Extensions/pgxntool#31
Summary
Tests and template updates for pgxntool commit 20c2552:
make-results.bats: new test verifyingverify-resultsblocksmake resultswhen tests are failing (exercises the fixedresults: test verify-resultsordering)test-verify-results.bats: removemake resultsassertion that now requires PostgreSQL (sincemake resultsrunsmake testfirst after the fix); add clarifying comments04-pgtle.batstest:pgtle.shcorrectly handles multiple spaces and tab before trailing comment in control filestemplate-multi-extension/ext_beta.control: use multiple spaces before trailing comment to exercise whitespace trimmingmulti-extension.bats: update comments for multiple-spaces testingtest.mdagent: fix debug level description (BATS 1–5 scale is separate fromlib.sh10–50 scale)gather-repo-info.sh: add sanity check that flags multi-digit non-multiples-of-10 debug levels