feat(sidebar): filter tasks by workspace type#3248
Draft
MattPua wants to merge 2 commits into
Draft
Conversation
Add a "Task type" section to the tasks sidebar filter menu with multi-select checkboxes for worktree, local, and cloud tasks. Classification uses Workspace.mode, falling back to the cloud run environment. Tasks with an unknown mode always stay visible. Generated-By: PostHog Code Task-Id: 19431e3f-90a3-4440-910d-33b5ce011955
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
Generated-By: PostHog Code Task-Id: 19431e3f-90a3-4440-910d-33b5ce011955
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
No way to filter the tasks sidebar by where a task runs. When you have a mix of worktree, local, and cloud tasks, the list gets noisy and there's no way to narrow it to just the type you care about.
Changes
Workspace.mode, falling back to the cloud run environment when there's no local workspace.Unchecking all three leaves only unknown-mode tasks visible (literal filter semantics).
How did you test this?
@posthog/core+@posthog/uitypecheck cleanfilterByWorkspaceMode(4 cases) -- all pass via vitestbiome lintclean on changed files, nonoRestrictedImportsAutomatic notifications