chore(stamphog): Raise auto-review line ceiling to 1000#3246
Merged
Conversation
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
Contributor
|
Reviews (1): Last reviewed commit: "raise stamphog line ceiling to 1000" | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Stamphog hard-refuses any PR over 500 changed lines, and team-code PRs keep landing just over that. Per Julian, this repo owns its copy of the agent so the limit is ours to tune. Upstream's
.stamphog/policy.ymlconfig doesn't apply here yet: our copy predates it and hardcodes the gate.Changes
Raise
MAX_LINESfrom 500 to 1000 intools/pr-approval-agent/gates.pyand update the README.MAX_FILESstays at 20. The refusal message inreview_pr.pyinterpolates the constant, so no other references exist.How did you test this?
No tests run. Grepped the tool and workflow for every reference to the ceiling; the constant and one README line are the only two.
Automatic notifications