fix(settings): use replace navigation to skip settings route when viewing usage#3240
Merged
Merged
Conversation
…wing usage Generated-By: PostHog Code
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
Contributor
|
Reviews (1): Last reviewed commit: "fix(settings): use replace navigation to..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Clicking "View usage & spend analysis" in settings dumped you on the new-task chat input instead of the usage page.
The button called
closeSettings()(asynchistory.back()) thennavigateToUsage(). The back-navigation won the race and landed on the previous route.Changes
navigateToUsage()takes an optionalreplaceflag./usagewithreplace: true, so back from/usagestill skips settings, with no racinghistory.back().How did you test this?
pnpm --filter @posthog/ui typecheck+ biome lint pass.Automatic notifications
Created with PostHog Code