fix(cloud-task): relay questions over the durable event stream and park unanswerable ones#3199
Merged
Merged
Conversation
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
Contributor
|
Reviews (1): Last reviewed commit: "fix(cloud-task): relay questions over th..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
With durable event ingest enabled, cloud task views receive permission_request frames through the durable stream instead of the sandbox SSE relay. Treat an active event stream sender as a reachable client for AskUserQuestion and permission requests. When a question still cannot be relayed, return a cancelled outcome that tells the model to restate the question and wait for the user instead of selecting an answer automatically. Cancelled outcomes carrying a message now reach the model as a denial so the parked-question instruction is delivered. Generated-By: PostHog Code
tatoalo
force-pushed
the
posthog-code/fix-cloud-question-relay
branch
from
97cbb2e to
0d1d10d
Compare
tatoalo
added
the
Stamphog
![stamphog[bot]](https://avatars.githubusercontent.com/in/3000332?s=60&v=4){kind=small}
stamphog
Bot
removed
the
Stamphog
Contributor
|
Reviews (2): Last reviewed commit: "fix(cloud-task): relay questions over du..." | Re-trigger Greptile |
jonathanlab
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
AskUserQuestionprompts in cloud runs stopped surfacing to the user; the agent's question fails and the model then picks an answer on its own. Closes #3082.ph_code_ask_user_question.mp4
Root cause: question (and permission) relays in
createCloudClient.requestPermissionare gated onsession.hasDesktopConnected, which is only ever set by an inbound SSE connection to the sandbox'sGET /events.