fix(skills): ignore hidden directories when walking skill files#3177
Draft
adboio wants to merge 1 commit into
Draft
fix(skills): ignore hidden directories when walking skill files#3177adboio wants to merge 1 commit into
adboio wants to merge 1 commit into
Conversation
Cloud skill bundling walked every file under a skill directory, so a .venv or similar hidden directory inside the skill folder blew past the 1000-file bundle limit with an error that named neither the skill nor the cause. Skip hidden directories (and the existing junk names) via a shared predicate used by both the cloud bundler and listSkillFiles, so the skill contents UI and team-skill exports match what a bundle uploads. Hidden files like .gitignore still count. The bundle limit errors now name the skill, its path, and the remedy. Generated-By: PostHog Code Task-Id: 78d26270-9485-4378-bfc0-f35b27af7bbf
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
Contributor
|
Reviews (1): Last reviewed commit: "fix(skills): ignore hidden directories w..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A user hit
Local skill bundle contains more than 1000 fileswhen invoking a custom skill on a cloud run. Two issues behind it:.DS_Store/.git/node_modules/__pycache__, so hidden directories like.venv(easily 5–20k files) counted toward the limit and got uploaded.dependencies:that the user never tagged.Changes
isIgnoredSkillEntrypredicate. This extends the existingfindSkillDirsrule that hidden dirs are never skills. Hidden files (.gitignore) still count.listSkillFiles, so the skill-contents UI and team-skill exports match what a cloud bundle uploads (previously that walker skipped nothing — publishing a team skill would ship a.venvto the skills store).Skill "alpha" (/home/u/.claude/skills/alpha) contains more than 1000 files. Cloud runs upload every file in the skill folder, so move data and build artifacts out of it.Left alone: the 1000-file cap itself (only the PostHog server's 30MB artifact size limit is a real platform constraint; raising/dropping the count cap can be a follow-up if legit >1000-file skills show up), and the marketplace install direction (unpacking downloaded archives stays a faithful copy).
Testing
skill-bundler.test.tsunzips real bundles: hidden dirs and junk excluded while hidden files and nested content survive; 1100 files inside.venvbundle fine (the reported scenario); the limit error names skill and path.listSkillFilescase inskill-discovery.test.ts.tsc --noEmitand Biome clean.🤖 Generated with Claude Code