hi-cuda: apply cargo fmt to unblock the fmt·test CI gate#86
Merged
Conversation
Recent hi-cuda work (commit 09fbc0e / 3fc2ca8) landed with a few method-chain and array-literal expressions that stable rustfmt wants wrapped, so `cargo fmt --all --check` — the blocking `fmt · test` CI job — fails on main. Pure `cargo fmt` normalization; no logic change. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The recent speculative-decode work added `speculative_greedy_next_tokens_paged_with_page_table` (and a call site in `process_continuous_decode_chunk`) to the `#[cfg(feature = "native-cuda")]` impl, but not the matching stub in the `#[cfg(not(feature = "native-cuda"))]` impl every sibling method has. So the default-feature build — which CI's `cargo test --workspace --exclude hi-mlx` uses — failed to compile with E0599. Add the stub (bails with the standard "built without native-cuda support" message), matching the call site's signature. No native-cuda path change. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The blocking fmt · test (CPU crates) CI job runs
cargo fmt --all --check, which covers the whole workspace includinghi-cuda. Recent hi-cuda work (commit09fbc0e/3fc2ca8) landed with a handful of method-chain and array-literal expressions that stable rustfmt (1.97) wants wrapped, so the check fails onmainand on every PR merged against it.This is a pure
cargo fmtnormalization ofcrates/hi-cuda/src/{lib,gpu}.rs— line wrapping only, no logic change. After it,cargo fmt --all --checkpasses.🤖 Generated with Claude Code