PeriodicWeapon by AGAGUGUG · Pull Request #2216 · Phobos-developers/Phobos

AGAGUGUG · 2026-05-17T15:05:57Z

The function of this property is to periodically fire weapons at all targets within its range. Currently, it determines which targets are locked by polling the units within its range. Currently, there are the following key-value pairs PeriodicWeapon= PeriodicWeapon.FiringDelay=
PeriodicWeapon.Range=
PeriodicWeapon.AffectsHouses=
PeriodicWeapon.UseInvokerAsOwner=
PeriodicWeapon.FireAll=
PeriodicWeapon.AffectTypes=
PeriodicWeapon.IgnoreTypes=
When the value is 'no', it will only fire at the nearest target within range that can be filtered; when this value is 'yes', it will fire at all targets within range.

TaranDahl · 2026-05-17T15:12:50Z

Docs needed

github-actions · 2026-05-17T15:18:12Z

Nightly build for this pull request:

compiled-dll-bc33fba9a0f439a5843984bbbd2960675f78add7.zip
These artifacts will expire in 90 days and will not be available for download after that time.

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

The function of this property is to periodically fire weapons at all targets within its range. Currently, it determines which targets are locked by polling the units within its range. Currently, there are the following key-value pairs PeriodicWeapon= PeriodicWeapon.FiringDelay= PeriodicWeapon.Range= PeriodicWeapon.AffectsHouses= PeriodicWeapon.UseInvokerAsOwner= PeriodicWeapon.FireAll= PeriodicWeapon.AffectTypes= PeriodicWeapon.IgnoreTypes= When the value is 'no', it will only fire at the nearest target within range that can be filtered; when this value is 'yes', it will fire at all targets within range.

phoboscn-bot · 2026-05-18T04:48:24Z

To Chinese users:
This pull request has been mentioned on Phobos CN. There might be relevant details there:

致中文用户：
此拉取请求已在 Phobos CN 上被提及。那里可能有相关详细信息：

https://www.phoboscn.top/t/topic/467/4

TaranDahl

You should really read this first: If all is clear - you should get in touch with maintainers of level respective to the complexity of your PR (see Types of contributions) to review/merge your upcoming PR and talk with them about key design aspects before you even submit a contribution.

TaranDahl · 2026-05-18T12:38:32Z

    - `ExpireWeapon.UseInvokerAsOwner` can be used to set the house and TechnoType that created the effect (e.g firer of the weapon that applied it) as the weapon's owner & invoker instead of the object the effect is attached to.
+  - While an attached effect is active, it can periodically fire a weapon at valid targets within range.
+    - `PeriodicWeapon` sets the `WeaponType` to fire on each interval.
+    - `PeriodicWeapon.FiringDelay` sets the interval in game frames between firing attempts; must be greater than `0` for periodic firing to run. The timer is initialized to this value when the effect is attached.


.Delay is enough.
Also, .InitialDelay may be useful.

TaranDahl · 2026-05-18T12:41:14Z

+    - `PeriodicWeapon` sets the `WeaponType` to fire on each interval.
+    - `PeriodicWeapon.FiringDelay` sets the interval in game frames between firing attempts; must be greater than `0` for periodic firing to run. The timer is initialized to this value when the effect is attached.
+    - `PeriodicWeapon.Range` sets the targeting range in cells from the object the effect is attached to. This value is used for periodic target search instead of the configured weapon's own `Range`; must be greater than `0` for periodic firing to run.
+    - `PeriodicWeapon.AffectsHouse` controls which owners' units can be targeted, using the same house enumeration as other attached-effect weapon filters (defaults to `all`).


Should reuse CanTargetHouses

TaranDahl · 2026-05-18T12:42:48Z

+    - `PeriodicWeapon.AffectTypes`, if set to a non-empty list, restricts targets to the listed `TechnoType`s.
+    - `PeriodicWeapon.IgnoreTypes`, if set to a non-empty list, excludes the listed `TechnoType`s from targeting.


Should be a thing on the weapon side, I think

TaranDahl · 2026-05-18T12:57:42Z

+    - `PeriodicWeapon.FireAll`, if set to false (default), fires at only the nearest valid target within range; if set to true, fires at every valid target within range on each interval.
+    - `PeriodicWeapon.AffectTypes`, if set to a non-empty list, restricts targets to the listed `TechnoType`s.
+    - `PeriodicWeapon.IgnoreTypes`, if set to a non-empty list, excludes the listed `TechnoType`s from targeting.
+    - Valid targets must be alive, within range, pass the house and type filters, and not be immune to the weapon's warhead armor modifier (`versus` not `0`). The attached object itself is never targeted. Weapons are fired via simulated firing from the attached object's location.


The attached object itself is never targeted.

May not be good to hard-code that.

TaranDahl · 2026-05-18T13:09:15Z

+    - `PeriodicWeapon.Range` sets the targeting range in cells from the object the effect is attached to. This value is used for periodic target search instead of the configured weapon's own `Range`; must be greater than `0` for periodic firing to run.
+    - `PeriodicWeapon.AffectsHouse` controls which owners' units can be targeted, using the same house enumeration as other attached-effect weapon filters (defaults to `all`).
+    - `PeriodicWeapon.UseInvokerAsOwner`, if set to true, uses the house and techno that applied the effect as the weapon's owner and firer instead of the object the effect is attached to.
+    - `PeriodicWeapon.FireAll`, if set to false (default), fires at only the nearest valid target within range; if set to true, fires at every valid target within range on each interval.


I think more customizable target selection method is needed.

TaranDahl · 2026-05-18T13:38:34Z

+bool TechnoExt::IsProjectileEligibleTarget(WeaponTypeClass* const pWeapon, TechnoClass* const pTarget, TechnoClass* const pFirer)
+{
+	if (!pWeapon || !pTarget)
+		return false;
+
+	const auto pBulletType = pWeapon->Projectile;
+
+	if (!pBulletType)
+		return false;
+
+	const auto pBulletTypeExt = BulletTypeExt::ExtMap.Find(pBulletType);
+	const bool inAir = pTarget->IsInAir();
+
+	if (inAir)
+	{
+		if (!pBulletType->AA)
+			return false;
+	}
+	else
+	{
+		if (pFirer && pFirer->GetTechnoType()->LandTargeting != LandTargetingType::Land_Not_OK
+			&& pBulletType->AA && pBulletTypeExt->AAOnly)
+		{
+			return false;
+		}
+
+		if (!pBulletType->AG)
+			return false;
+	}
+
+	if (pTarget->InWhichLayer() == Layer::Underground && !pBulletTypeExt->AU)
+		return false;
+
+	return true;
+}


Should generalize and reuse SplitsProjectileCheck

TaranDahl · 2026-05-18T13:39:21Z

+		if (!pTarget || pTarget == pTechno || pTarget->InLimbo)
+			continue;
+
+		// 1) 距离检查
+		const int dist = pTarget->DistanceFrom(pTechno);
+		if (dist > searchRange)
+			continue;
+
+		// 2) AffectsHouse 检查
+		if (!EnumFunctions::CanTargetHouse(pType->PeriodicWeapon_AffectsHouse, pFirerHouse, pTarget->Owner))
+			continue;
+
+		// 3) AffectTypes / IgnoreTypes 检查
+		auto const pTargetType = pTarget->GetTechnoType();
+
+		if (pType->PeriodicWeapon_AffectTypes.size() > 0)
+		{
+			bool found = false;
+			for (auto const& pAllowed : pType->PeriodicWeapon_AffectTypes)
+			{
+				if (pTargetType == pAllowed) { found = true; break; }
+			}
+			if (!found) continue;
+		}
+
+		if (pType->PeriodicWeapon_IgnoreTypes.size() > 0)
+		{
+			bool ignored = false;
+			for (auto const& pIgnored : pType->PeriodicWeapon_IgnoreTypes)
+			{
+				if (pTargetType == pIgnored) { ignored = true; break; }
+			}
+			if (ignored) continue;
+		}
+
+		// 4) 抛射体 AA / AG / AAOnly / AU 索敌检查
+		if (!TechnoExt::IsProjectileEligibleTarget(pWeapon, pTarget, pFirer))
+			continue;
+
+		// 5) 弹头护甲比率检查
+		const double versus = GeneralUtils::GetWarheadVersusArmor(pWH, pTarget->GetTechnoType()->Armor);
+		if (versus == 0.0)
+			continue;
+
+		// 6) 存活检查
+		if (!pTarget->IsAlive || pTarget->Health <= 0)
+			continue;
+


Should generalize and reuse IsAllowedSplitsTarget

TaranDahl · 2026-05-18T13:41:19Z

+
+		for (auto const pTarget : validTargets)
+		{
+			const int d = pTarget->DistanceFrom(pTechno);


You checked the distance twice. Should do the sorting when you are looking for the target.

TaranDahl · 2026-05-18T13:44:12Z

+			if (!pBulletType) continue;
+
+			BulletClass* pBullet = pBulletType->CreateBullet(
+				pTarget, pFirer, pWeapon->Damage, pWeapon->Warhead,


Should apply FirepowerMultiplier.

AGAGUGUG force-pushed the develop branch from d169b41 to e930763 Compare May 18, 2026 04:46

Fix Read projectile AA / AG / AAOnly / AU check

c848f6d

TaranDahl requested changes May 18, 2026

View reviewed changes

TaranDahl added ❓New feature Needs improvement ⚙️T2 T2 maintainer review is sufficient labels May 18, 2026

		- `PeriodicWeapon.AffectTypes`, if set to a non-empty list, restricts targets to the listed `TechnoType`s.
		- `PeriodicWeapon.IgnoreTypes`, if set to a non-empty list, excludes the listed `TechnoType`s from targeting.

Uh oh!

Conversation

AGAGUGUG commented May 17, 2026

Uh oh!

TaranDahl commented May 17, 2026

Uh oh!

github-actions Bot commented May 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

phoboscn-bot commented May 18, 2026

Uh oh!

TaranDahl left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions Bot commented May 17, 2026 •

edited

Loading