Skip to content

fix(stream): read from sync iterables#2775

Merged
proggeramlug merged 2 commits into
PerryTS:mainfrom
andrewtdiz:codex/node-compat-readable-from-sync-iterables
May 30, 2026
Merged

fix(stream): read from sync iterables#2775
proggeramlug merged 2 commits into
PerryTS:mainfrom
andrewtdiz:codex/node-compat-readable-from-sync-iterables

Conversation

@andrewtdiz
Copy link
Copy Markdown
Contributor

Summary

  • materialize sync iterator-protocol inputs for Readable.from() after string/Buffer single-chunk handling
  • bail out of sync materialization when next() returns a Promise so async iterables stay on the existing async path
  • remove stale known-failure entries for sync generator/custom iterable Readable.from() cases

Verification

  • ./run_parity_tests.sh --suite node-suite --module stream --filter node-suite/stream/readable/from-async-iterable (expected residual; old empty-output shape, no runaway chunks)
  • ./run_parity_tests.sh --suite node-suite --module stream --filter node-suite/stream/readable/from-gen
  • ./run_parity_tests.sh --suite node-suite --module stream --filter node-suite/stream/readable/from-iterable-object
  • ./run_parity_tests.sh --suite node-suite --module stream --filter node-suite/stream/readable/from-string-single-chunk
  • cargo check -p perry-runtime
  • cargo fmt --all --check
  • jq empty test-parity/known_failures.json
  • git diff --check

@proggeramlug proggeramlug merged commit dea84ba into PerryTS:main May 30, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants