Skip to content

Add path posix and win32 submodule manifest entries#2765

Merged
proggeramlug merged 2 commits into
PerryTS:mainfrom
andrewtdiz:codex/node-compat-2712-path-submodule-manifest
May 30, 2026
Merged

Add path posix and win32 submodule manifest entries#2765
proggeramlug merged 2 commits into
PerryTS:mainfrom
andrewtdiz:codex/node-compat-2712-path-submodule-manifest

Conversation

@andrewtdiz
Copy link
Copy Markdown
Contributor

Closes #2712.

Summary:

  • Add path/posix and path/win32 to the API manifest, native module list, runtime-only module list, and generated API docs.
  • Alias direct Node path submodules to the existing path.posix / path.win32 runtime namespaces, including callable exports and sep / delimiter / recursive posix / win32 properties.
  • Add a parity fixture for default and namespace imports from node:path/posix and node:path/win32.

Validation:

  • PATH="/root/.npm/_npx/8758e404b5eed2f3/node_modules/.bin:$PATH" node test-parity/node-suite/path/submodules/direct-imports.ts
  • env RUSTC_WRAPPER= PATH="/root/.npm/_npx/8758e404b5eed2f3/node_modules/.bin:$PATH" ./run_parity_tests.sh --suite node-suite --module path --filter direct-imports (report test-parity/reports/parity_report_20260529_225711.json)
  • env RUSTC_WRAPPER= PATH="/root/.npm/_npx/8758e404b5eed2f3/node_modules/.bin:$PATH" ./run_parity_tests.sh --suite node-suite --module path (83/83, report test-parity/reports/parity_report_20260529_225817.json)
  • env RUSTC_WRAPPER= cargo test -p perry-api-manifest
  • env RUSTC_WRAPPER= cargo test -p perry-codegen --test manifest_consistency
  • env RUSTC_WRAPPER= cargo check -p perry-api-manifest -p perry-hir -p perry-codegen -p perry-runtime
  • env RUSTC_WRAPPER= ./scripts/regen_api_docs.sh
  • cargo fmt --all -- --check
  • git diff --check
  • jq empty test-parity/known_failures.json test-parity/threshold.json
  • ./scripts/check_file_size.sh

@andrewtdiz andrewtdiz force-pushed the codex/node-compat-2712-path-submodule-manifest branch from a6b0a01 to 07de8fb Compare May 30, 2026 03:02
@proggeramlug proggeramlug merged commit 9c29351 into PerryTS:main May 30, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

node:path: add posix and win32 submodules to the API manifest

2 participants