Skip to content

fix(assert): expose strict self alias#2750

Open
andrewtdiz wants to merge 3 commits into
PerryTS:mainfrom
andrewtdiz:codex/node-compat-2698-assert-strict-self-alias
Open

fix(assert): expose strict self alias#2750
andrewtdiz wants to merge 3 commits into
PerryTS:mainfrom
andrewtdiz:codex/node-compat-2698-assert-strict-self-alias

Conversation

@andrewtdiz
Copy link
Copy Markdown
Contributor

Closes #2698.

Summary

  • adds the assert/strict.strict API manifest entries for both property access and call lowering
  • makes node:assert/strict expose an enumerable strict self-alias matching Node
  • regenerates API docs and adds a focused parity fixture covering default, named, namespace, and parent-module strict aliases

Verification

  • PATH=/home/github-runner/actions-runner/externals/node24/bin:$PATH node --experimental-strip-types test-parity/node-suite/assert/imports/strict-self-alias.ts
  • RUSTC_WRAPPER= target/release/perry test-parity/node-suite/assert/imports/strict-self-alias.ts -o /tmp/perry_assert_strict_alias_2698 && /tmp/perry_assert_strict_alias_2698
  • PATH=/home/github-runner/actions-runner/externals/node24/bin:$PATH RUSTC_WRAPPER= ./run_parity_tests.sh --suite node-suite --module assert --filter strict-self-alias
  • RUSTC_WRAPPER= ./scripts/regen_api_docs.sh
  • cargo fmt --all -- --check
  • git diff --check
  • ./scripts/check_file_size.sh
  • jq empty test-parity/known_failures.json test-parity/threshold.json
  • RUSTC_WRAPPER= cargo check -p perry-api-manifest -p perry-codegen -p perry-runtime
  • RUSTC_WRAPPER= cargo test -p perry-api-manifest
  • RUSTC_WRAPPER= cargo test -p perry-codegen --test manifest_consistency

Ralph Küpper and others added 2 commits May 30, 2026 01:15
# Conflicts:
#	crates/perry-api-manifest/src/lib.rs
#	docs/api/perry.d.ts
#	docs/src/api/reference.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

node:assert/strict: expose the strict self-alias

1 participant