Skip to content

Unify "Change payment method" action across charge flows#130

Merged
Peter-John-paystack merged 1 commit into
mainfrom
fix/change-payment-button-fix
Jul 1, 2026
Merged

Unify "Change payment method" action across charge flows#130
Peter-John-paystack merged 1 commit into
mainfrom
fix/change-payment-button-fix

Conversation

@Peter-John-paystack

Copy link
Copy Markdown
Collaborator

Replace the standalone ChangePaymentMethodFooter and ad-hoc cancel/close
buttons in the bank transfer, mobile money, and Zap flows with a
consistent inline "Change payment method" button on each step.

  • Bank Transfer: add onChangePaymentMethod to the account details, confirming, taking-longer, and delayed-confirmation views; drop the state-driven footer and the separate Close action.
  • Mobile Money: rename cancelTransaction to userTappedChangePaymentMethod, routing through restartFromChannelSelection.
  • Zap: restyle the existing button to match (navy02 / body14M).
  • Add ZapRepositoryImplementationTests covering the standard-host URL, form-urlencoded body, field decoding, and Pusher response mapping.
  • Update bank transfer and mobile money view-model tests accordingly.

  Replace the standalone ChangePaymentMethodFooter and ad-hoc cancel/close
  buttons in the bank transfer, mobile money, and Zap flows with a
  consistent inline "Change payment method" button on each step.

  - Bank Transfer: add onChangePaymentMethod to the account details,
    confirming, taking-longer, and delayed-confirmation views; drop the
    state-driven footer and the separate Close action.
  - Mobile Money: rename cancelTransaction to userTappedChangePaymentMethod,
    routing through restartFromChannelSelection.
  - Zap: restyle the existing button to match (navy02 / body14M).
  - Add ZapRepositoryImplementationTests covering the standard-host URL,
    form-urlencoded body, field decoding, and Pusher response mapping.
  - Update bank transfer and mobile money view-model tests accordingly.
@Peter-John-paystack Peter-John-paystack self-assigned this Jun 30, 2026
@Peter-John-paystack Peter-John-paystack added the bug Something isn't working label Jun 30, 2026
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@Peter-John-paystack Peter-John-paystack merged commit 04eb6e9 into main Jul 1, 2026
4 of 6 checks passed
@Peter-John-paystack Peter-John-paystack deleted the fix/change-payment-button-fix branch July 1, 2026 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants