Skip to content

Add support for Deadeye's Thrilling Chase and Heightened Charges support#1860

Open
Peechey wants to merge 2 commits into
PathOfBuildingCommunity:devfrom
Peechey:feature/thrilling-chase
Open

Add support for Deadeye's Thrilling Chase and Heightened Charges support#1860
Peechey wants to merge 2 commits into
PathOfBuildingCommunity:devfrom
Peechey:feature/thrilling-chase

Conversation

@Peechey
Copy link
Copy Markdown
Contributor

@Peechey Peechey commented May 16, 2026

Fixes #188

Description of the problem being solved:

Adding support for "benefits from charges have x% chance to be doubled" by adding a scalar tag to Multiplier and MultiplierThreshold mods.

Also fixing a bug with Rain of Arrows "more projectile if consumed a frenzy" mod, we had ProjectileNumber instead of ProjectileCount.

I did test Thrilling Chase and Heightened Charges together for an expected 70% chance to be doubled, but there was an issue with how I was getting the Sum for "ConsumedFrenzyChargeEffect" for the activeSkill so I do subtract the Thrilling Chase mod so we don't double dip. I don't know if that's the best solution but if I didn't the activeSkill.multiplier was grabbing 70 instead of 20. You can see the change around 1193 of CalcPerform.

Added a test to validate Thrilling Chase and Heightened Charges play nice.

Steps taken to verify a working solution:

  • Validate Multiplier/MultiplierThreshold mult/values are scaled by the ConsumedChargeEffect
  • Validate Rain of Arrows projectile count MORE mod applies if frenzy consumed

Link to a build that showcases this PR:

eNrtHNlu4zjyufMVhIEBdjHdji3fgTMDx0k6AZKO10537-7LgJHomBtK9EhUEs9g_32rSJ2OD8qZh736IW2RdbAOFquosoc_v_qCPLMw4jI4rTXrjRphgSs9Hjye1r7eX37q137-6Wg4oWpxNz-LucAZ56ejD0P9QFxBo-gL9dlpbUqDRxbWCI1cFnjjfOKcUY-tWI08c_ZyKz0Yur6d3E3va0SwZyaAb434lAcz6T4x9TmU8fK01q4Rd0FD6ioW3iDYKFbSYKswBmqKho9MfUvX3vilWYN1fRhOBF2xcKaoIs9UxADfa9Zb7UbPGTTgT79bIxFMntZGIDd9ZOfUh7-144OQz-IwUnsogFbb_RRvtmTM2wrar7eK_1KkK6524_Xq7RR2ErKL-Zy5ij-zccjVeEEDd9fi-p0U1QLcKcLexkLxpeBg9a3wnYIMe2h3Bu16p9Ft9PSfZop4LxUV55PZVrxGGVKqqhy-c7U4E6DfnVzqzU63PWh2B51mt5nLdf0YcMV2YSLXbtfpdLu9TqffK3K1Q96y5InkkQwOWXOqKCutjmMhYNNbwU5ZxMJnqvjudW3RyFj6DzzYbYZWPd-CIaN3c-PsU-rxOLplKmTRdl9vDVLcWxrQsYzUfpEQcsJCiGlqJ0Kz3al3e84a2oy5EoJhVU4VMW_4nNlD2kizjlB1NYfJcTGzhatM-LAFTSGu20HOZCx2QmZePlPbw2Uz26Ln7HU7VLeVb7hfd0FmTK8DCxnO2bPErWsRaUP-EKvtobzdq_c6fafRchyn326V4s7F1WQrXjeTf7JYRdyl4pa-cj_24fS4p09s-9JyJjf8caECiFjVUS95yKpjjaXwbLFyAeEwlJEt2qAQJHhwRQNv5LoxJEcrC6vS8ClgUWQbvSH-7sPIpcC9vj3MF5Ie9wRBrwPXkujXIExWY4kwhW2NOdmD2JHsNBqbeSTRwS62TdkjCxJ2KzuUG8bcxWcw3ZTu2DWd0lFgEXNQrQi6S61lohZqLSipjLFPSaWzr6KSEMVOSYXlzZYcslB7yGrCr-NY-8hFwMLH1WzBmfCqQaf6GtOlpfWL2Lu8YAu7SjYqotrZqnSO2nHLTqyLZxpZnUVGDwbaTgXPUI_uqUVyx2RQGFTCmITyH1h-iWpoIIYQ1TEO5HbO5gLRJBoQzkprDFsGo9CXcWhpPQNsZbw0LzA195R5sWuXsmRF8ZmQ7pOtGBmWVnYl1JFS1H06l95jNYtWwiivbxYvlxCucCfsIfApPxYw6YGTn9tkuTnsHeziXWGqwADzI1sGOWwFBlnGZ8tlDWEfq0YpZ7MWJQfex6D5xpy3ECV9OG30tc-t3HGO1LM8tITzfQEh4WsEMs6euBDb09jCvVHEwGWsKuncIWJhdzejAS1vHCbyBfS1wPu97UtobYKGfHq_ki9DFvy2sqZfAt_FoHBQepCbgy6teaxj5GzO4vk8Iq70H6i6AVcCOYhZEUmpkweAMXM1AlVBxJIHQ-Ge-3CGRdE5VZREjIbuIgXOny6pEA8QrnDUS8rAbzTkNFCOVt3aYNPoU1_YXnKhWHgOVFAC1AMyHh7rG2L8pD0wAuhQfWZ-dLYCL0hvcaOFfMGwZebuV0sWQei8uUGOcxoLHL0xt8SBDP2sICzO_yWmgquVtgA10RA5zphKVlnge4nZS_mqSWspxSDcQyQcSwb11fQoJ5tdVxfGxlS4kZ4Q9AHXWiM8cEXsQcWTbJHT2pyKiOH9OtYoXqIAzejDENanXQFWcB147BWk5aJGHpl_7WESoqgH5ju-ViDHMQpzrPnCJ0xTqfgmhWCrWolGsihNyDD9LOQDFc1M90gC6RdpGC8tYzgphivjwCi1LAU4tHaLdWI1ElAfzyY3HSfpRHL174DNfs3td3ygPo4LPvQi53CKHKwLQ-iK4RnBwEWSbfZuvbyhmHAq6iiHyXd3_o7kjZ6Gxgv-3Z21YJxLFkoXZHindVIy7zZKSmiDLfKl7rDAIcpINu61y2YLqQ7VRIL-bg1ky8glhyFixnZt0v8Q58sjZZb1gZQ0PFTvZSrvVv_6onIrZDMkmfp_xPyfiZi5005hJXfzURjKl-hQAxVpvNso5QXlhsBxIucknbEMHclHEErnjCZVxI9aFySOmHlf853RpQx0SpcoWmeOoI9zDkVTiKVLlC7XJIFIIckBNSd8LqZ3UxBKrU7IdDS9OPqxTS6ELp8gRzmTL0ffaehL7GjQT-OQzhXzTggyOIJaac5fT8jvIfY8nDTqnX_eSJeKkecxD2tkczvR3w2Ita4VYBYJUugZJPyboK8DN2Q0Yp65e9CFoLMVGl_h41XKTIX8KblxaG2CNl6S3zRlARVNbAzTPkqS8BPiNI70xJT9ekJ6vaNrfyk4HKTRCWkcgTwR6bSIkqTfJagqYoQyM-0ezvSaBHVTmungRLPlkDwsJtM_OvX2DzibykOuuCJGnKPBD7hTjVKI0QrRakGDA45eKbot1D8kl5AYP9S-CtW3bm0hWiFYcXdqiRsl3rwVwtkL0doL0d4L0dkL0U1KQR1gynvB2bwX1g6fo0uxyh_2bgbjE9l-MobqVHTyFPqLDFglj2_9UR6v736rOHu_6OzO0WcgqCLjSydGd-R-AeHxqMDqT07nU6vz56KfFv0QBSIvXC2IWvCImAXs2xL9RpFcHtfMtCFnFBbt3j5Np8r-0fr679w6OyB6GzcXXiXsOLxKtwxCKsIBZ_LwdXqDyUWg--YMFoHTGCevi2rbhjLyY8FUjtDYh3DFhF8JIVmUUwHlTHorkrwPsMeCLfiMyVwFNlJF1SVpktkLXVbAm-JGc6oitA7QcdWVYQLsV1raDasmiuFQRRawe9GDLTlUwThjQlW1RrOijpoVJa6i00tBo6cDMN6uyYQgk0p_GN6H1IP4gze833WRFJlrWZ1Y4yddQJiAFSxjlRD3eeT-gjfK2GuLFUeoe4EvLi8vxvfX3y4SVkUUXWj8EsT-A1YW5v8s-g5n5j2jDnlJro8vEoF0_BCZudPaN85e9OQ51EJcRFiLCEGXEdYgJma-pQYHVdJ6W6Kl6RTmLChBsu-GHMNNkdDFKwvx5Wg-a0HqXKoNyzFrwVffeB1vRch0_JZImQN4TCOlX7vbUMFTvUwER-xEgWSGijXlpmM2AqDgeKOPVVq0QSkKb_uheORz7iYwdlZPXm6WdZM2RNnQ0N2-ZfxkyALZ9N2WsdMxG63qnt81rSZjNv7FXLoqYydDFshZ20aZQDYsgyt0FwtKkFSOuMC8cs2ykK5rZ4d9kwNYELyFuGNef64RvFMLFmYzFpRgl5j2xOjN7snGbXSFrW1lNekRG1mwfauEakasdj1_s2PTMRuzFHuPysGsNGNBKnnPXSJixizNkGR8JRMkYzaSJP0_ZSHSQZuNokPu6Fly7220eDP5XoK6NeQPWBc2f_wBZLL2HitaOqFY2y3p2IHoX6F8hQp5AxV9RWdHBDfc-yjgvnsfBZ2QWmFP32Qi0_X8YwtmdnO9zvjRMlZtJJA1FRy8BNNocPgKdGuGDXcM_uCz-hJ3Q_TPpywPks20ZioOzkEl1vtiz7I2h4_DREzOyo2SbqFoIoBpHN8Q3JIJ61CyjRAc5Fe2GeNWSllj0xWjAr-6JMX7CK53zr-LGHalxksaeCm5u02JemUzSBUBTd0Gc47Nr-_VYcD81QZC2bqGx2lJN_wiIc1B0jiaPgzHMpjzx-T1iHkoviDJRojiSuhvbuoWm_J1VbHyiyNW7qYiD2BZRoOitsooWAOF3FvHS6vG7IprIqjLFlJ4LEwr0-zrhukrH_UZ_kCVi-8RPCsaDHWIFVBaHKY4rYYFUlp3pEidPThpT1SO4exlU2gxzLB2IHnMl8GlDP2Zvs4tKKFho0ld2q6-gh_BHgCFipWVGmcLyHbecLTQIF4wf2dUf71kHX-XbsYLvDioyDDLFjOEZq9jpRWOIZl5muEYX4rOmJgX6OwzfKHlNXeWfaZfb2O1xyw3ReeIg-6-heYvKy2xZq4M3UVl06NXv9ly_e4etLRcSDH6jW7LQvPV1ZDctaQIvUajUhga-b6sGIMQfMIKvtmy4YgZTFBxr5Z9q7puUKO2K81Eq-78-CKpYGlnO3zEH7m4m-vkEhzR9vgwEdl8bQAOT_0yp2hyWw1u0gWcvOnZac5h_YQf70PG8HJzV7vCb1L6fz2tfXKcQaPeafeancZAf_sfJ_4GE-1-rz4YOI0OAHS7vbRxd6ZCvBRGqKRFtmnkH1772CdD2Cv-N6EhNl_k-YZeVNopq5s3kgQAH8xPOphbZeCDr69ouBrlP-qAU7rpJJAeytDq9BvNj51GuzP42Oq1Wt2P7e5g0PjotJ1BB1tpIsXCVXKBg-ulZVrNWsIyALiA6o4Vp0YUKi7_cYd2igfn6aoIan52Ik1Ovk5vTMvNQqlldHJ8_PLyUl9StZBz9soFq7vSP14CNxD9k763_oSMjkfw7-xxdDZqP__9yVuwzstoZDpVUopD8-sUUeIld0kaEyUdPtnlUjpBPPb6xWgIu4VU9jlSYfo57YYpERseoxm0G6Gd8IO2ILbkvYy8Z0wo7iHLirKXiYCoeECTKxYBpqHLJaiqYPPh8Zuf8PgXVzoUjA==

thrilling chase
image
spiral volley is 100% if consumed frenzy, 30% per frenzy
image


heightened charges
image
spiral volley is 100% if consumed frenzy, 30% per frenzy
image


thrilling chase + heightened charges
image


rain of arrows
image

Peechey added 2 commits May 16, 2026 11:22
add support for Heightened Charges
fix Rain of Arrows consumed frenzy mod
@Peechey Peechey added the enhancement New feature, calculation, or mod label May 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature, calculation, or mod

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for Deadeye Ascendnacy

1 participant