Add support for Tabula Rasa and Sekhema's Resolve#1854
Draft
Peechey wants to merge 1 commit into
Draft
Conversation
add support for Sekhema's Resolve jewel restriction update Tabula Rasa, Sekhema's Resolve unique bases with "Sockets J"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Adding support for Jewel Sockets, primarily Tabula Rasa and Sekhema's Resolve but ideally anything else in the future. Most of this code was copied from the Abyssal Socket work in pob1 with a rename and I haven't given it much scrutiny yet, so there could be things to optimize. I'm also supporting the Jewel Restriction from Sekhema's Resolve, though done rather crudely. Wouldn't mind some eyes there.
Item Trader is updated to show the Jewel Sockets when applicable.
Tested character import with both items. Copy paste works with the items but does not bring along the jewels.
The solution utilizes the "J" character in the Sockets string, which comes in through the two aforementioned cases, but I also added a fallback/backwards compat for older builds to add the sockets if the "Sockets: J..." lines aren't present.
On save, only the shown slots are written to xml, so even though there are technically 6 jewel sockets under basically every slot, we aren't saving all of those all the time.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
After screenshot:
Item Trader
Character Import