Skip to content

Add support for many "All Damage can Contribute" mods#1845

Open
Peechey wants to merge 3 commits into
PathOfBuildingCommunity:devfrom
Peechey:feature/all-damage-can-contribute
Open

Add support for many "All Damage can Contribute" mods#1845
Peechey wants to merge 3 commits into
PathOfBuildingCommunity:devfrom
Peechey:feature/all-damage-can-contribute

Conversation

@Peechey
Copy link
Copy Markdown
Contributor

@Peechey Peechey commented May 12, 2026

Description of the problem being solved:

Primarily supporting "All Damage from Hits against Bleeding targets Contributes to Chill Magnitude" and "All Damage from Hits with this Weapon Contributes to Chill Magnitude" but I've made the parser rather modular so this should hopefully cover all combinations possible given the wording matches. There are some redundant flags being set/pseudo-set like CanChill will technically apply ColdCanChill but it allows regex in parser instead of manually configuring the combos.

Known affected Uniques:

  • Tidebreaker
  • Icefang Orbit
  • Venopuncture

With Tidebreaker, any damage should have chill breakdown in Calcs
With Icefang, any damage with Poisoned config should have chill breakdown in Calcs
With Veno, any damage with Bleeding config should have chill breakdown in Calcs

Added a really basic test for Tidebreaker... I wanted to get Veno and Icefang in there too but something's off about setting those configOptions in a test.

Update

Added parsing for The Three Dragons
image

Build:

eNrtHGtv4zbyc_0rBAMFdrFNLMmWnQRJC8dONgaSTWon27tPBS3Rti606JWoJG7R_34zpJ6OZVNJi7vDtR-yEjUPznBeHNI9_ellyYwnGkY-D86a1qHZNGjgcs8P5mfNh_vLg6PmTz82Tu-IWNzOzmOf4Rf7x8Z3p_LFYPSJMkBsGi4jUfSFLOlZc0yCOQ2bBolcGniD_MOQEo-uadN48unzDfdgaHRzdzu-B_QFCYkraHiNFPux4Oq7CGOAFyScU_E1naf5KzBcEj-YcPeRis8hj1c4CZjXd6d3jKxpOBFEGE-ExUCjbZmH3Y7T7pqO3evYTSOCj2fNPshN5nRIlvC32XoT8nkcRmIPBcC3O2bPatt2p909clISkxWlXiVWBnYX0ovZjLrCf6KD0BeDBQncam72YSdD1QEvwt7ETPgr5sPiVcF3jlOEq720reP24VG3c9Q1jx0QPkW854Kw4d2kWmFlSC6qZ398aHUtp21adruXYp0z0Osu-lbHOTwye13H7Fr5cii03Uu5lV86Sy2RBjFj4EJasGMa0fCJCLD5XfAdpwtrDnOyQLDjfEH5cuoH1Os_zXcYSyZ-P6TkdqYsbUw8P45uqAhpVIl7nCnghgRkwCOxXyKEvKMhhAWxE6FrHjrtzrF1ZPe67V5nA31CXQ5xpS7HmpjX_ozqQ-pItYlQdzZvk-NiogtXm_DbJjQGD9ODnPCY7YRsZ9Y-EdUxy-q2c5f6thMyc4chfamEygx_FGgIMaRPHF1YI9yF_jQW1dHnyDm0u2bbsY8cSCdOKf5cXN1VS2UdZclksY58l7Ab8uIv4yXE8HvySKvn1jvODXC-EAGErvqol35ItbE6efxini5WQULISTzSxTsuxAk_uCKB13fdGAqRtca6kvAxoFGkG8cxuezBKIiB_r6_NoASwj1B0FHg6lJ9CMJkProYY3BuLHembEeuN83tTJIYoRfhxnROg4TdWg_lmlJ38RlWDxjBelfrrJQSNGIPqhZBd6m2TFRHs2YFxj412UW0mmpCFF01FSY4WflhHch64m_iaNvJRUDD-Xqy8Cnz6kGnGhuQleb6F7F32UEFu1qrVETVXa1STtXjlyWviycSaaUlpQkFraeEJ9jm7dkb5MZJoe6uhXEX8n_hdojVQwMxGKuP8UZuQzpjiMaDMRTwwVwbQ5dBP1zyONRcPQWstXhphaB2QmPqxa5e9ZJtUs8Z7Mp1xciwpLJrofaFIO7jkHvzeitaC6M8v0m8WkHAQk_YQ-AgTw1Y_kAJ4OtUvDnsLXjxrkB10DWLlZIugxx2LwPHfFX76XLZQNjHyiwVb9qi5MD7GFivlvMGouQS8o1swtzw6kzSKfRhIgpLrrU5zhcU9vtam30JqNlEuOPPIO8Cm2LVU2hvg4bCWGMqIQ1-W2vTL4FrMbgIPCiyQZfaPDYxcjbn8WwWGVP4ew2GcNZsGlDARzR74cspEcmbwrj3l5BzomhIBDEi2UG89Jmg4RCgkIeaKSWhu0jJ5G-XhLEpxB0c9ZKt3VcS-iQQtjS0jUELB5HxaUu2TPFpwIOZPzeI6unJlwkVWQczGzGEL5jsm85IzETT8L0U6LvTUbCKBagnlL3acw77CiOQbVYa0OV6FMmhVhE4iJdTGqqytQAqW65lyCnnjJLgrDkjLKIp9LeYRqLvCsMawNdwhhGb-iGpwFW9W4WK7QEf1XKBHGWvLcuKcuVduoDQRMNsklavV5olhsZie247ll0WDbuamM1-oURuvSaYMqKdbKtVsw28_Zrf_kn2ykhJquWMyc651uyWWat2IuIgoFjcQjhj6zoqLed6Lb6RP_fZ7UzGFFBm5rx62tlIVHqzzJLJ_mlu8NvMvHr8cJb7WR2ZRyWsYj2mvXa_QFQJ1w-R3vJ1unaJZamC347ivLLOYt2yZ54Tl0PQq-EykwVEUw14Z4smfLGgIfUk9oDHkJkpm2lxHSx8qMz2ct0wxc1KQ3vNhj7UEJDyRH-55Ghh3k5Xt16zreFuW9h-hj-wEdnLecMXttZwFdwzTI8ueXDJw-V-9W4E3jSX7g6DZZzigVgrS4Iydao3fLwPKU0yJ25tsqSJL-oQcuQlCRxzDgnX_fwYEj8FPisdTY68_PxyFEAZEBCGY-hr3KMRpsuOc_xDp3uM7cIliQBmrQrJCKsARQuEXRfR1SEoEIY6kRZOLjtJ-n4YX8uH7xZCrKKTVuv5-flwRcSCz-gL7DYPoXJprWBOIOhB9AgmfoCUWn3473zeP8d_JaFWSulUnYZGicaxJg59EECxOYXtkuovpx-wdviiJITKIhDZs0df0ueEVqtE7LSFypbrgquBD6PliofCoC_4zx0JxTotHWTpM8H5R1BsheIzXUbnayhzL7HRkR9TYeFbBkgLCE9VPzB-rU6bAzDIrIXdTI0BWSRVlBEt-DPu1RS5-_UKhelfXxeJ_RwT5uM8zcSAEgKlIksOyqPmfs5lQJgbST4bH-QYI1OcJKrUZbFHR0GyB0hMD7x3yqiXSJcsDswnPUtHR_qWz82Y0yXaE2w4iAcVa2skQEEt1FJLMpV6IasJI0vlTcotcMxQg4rjZ8anhNmpVouDVnkwnZshzQ6ZpwxUhY5VNQRoKe2TqnKLQJnRyOklBpMoVxqNsgZpNiiLEUdUnR9BlbbigVzEpO5Ua4tgpaWFPUEaD11c2kyVkmJxBccwP7E-MR6-jH5-uGh8pQFfxYEr4pA2RiEPjDGExAZMfR7TE2NIngODzwzIRcYViNiQFjem306MdrcBRs581xfRiWE1fofiJzpZJRXUD0Q2I_7oe15kWIbgRsdIqytDxXscVC2LqAL59xBjxol56Cg6H5yD3kdE-3B8YLU_7idIUhcvkvr0wTYP2qYkNIEQEszFIoF3IR7_0Wc5QTwsMWYhXxpXIKbxDJmVGmmxbkAQTuhHSOyGzANfgIWjxmQSNkCfax5XUM_pkjn4TSRyyup-R7TJQRHN-DQKUn2wzAPb_Pg9XhwBG0BoP5jB8hSowmyA3X5lf7CcA9sBWuCxISVQjZVlywiCbCkXaeE33JNh3pC08KaHk-7REh-ohLD3QrT3Qjh7Ibp7IXppvkXHKXuQXfagcX980chM0L4CHbm0cUkCAjssA6oSyF1kuaRhYxCSmaDeiYFu2bgL6cx_OTEKCr_mQGKUKru8C0nOAZw34vXzIzzVeK0mBD62SeT-meMhYLcxiWe7mSvHkxVLuxI63X2C2_mPSctxK7QKw7IVnsd0iDzJfFRc7DSSlHVi2GYhMvWOtkWmxMwV6wjyHizaZAVFziLxx4bVs4smvxFdGjIE2R0Zy6xXXz9ZlgxzqbINpe3GJ_uw87303UR2dEFDid6wSgyVCg2pw8anLiJJodDlCPo9qsNQyeKvd6bOf9rd2lsT1siFggVCz204hVD2_5exhvQFamrQyJ7gf8f9CHRTCvl66U1hgj3-6ekto_yW9LY7JSXi_pclpM5f6yGdrR5yD9uSKejoETIPqAW2YKirmFW7yPYw2nGK7mKWVwMM0nLMj7viZdmAD9ofdwe0CnvHLSRj_hwL2yLMgECVDA4GswDTL88EO4CGbC7Hq8ZWi3z2xQLk9yNDpZJ9lvg_YUtOtaU4Wy3lC302EGRr0aKTW80Kdt2_Q_ffofvv0L09dGNLZccOv9RtYVwkDcF-uDRs-CpU98NUj3fTh_F13pYqwCdxzTImz2RVA--azg3rDXxyFGcfSn8ZMypq8LiibFkLAQ9F66nrnHtrIzmy0MeCbcoTjWqx4aIOPMbHom6tfQiXsKF5rCW5ZNGurdw6NqImVQfjnLL6611HiH5NERIzt9_iTm9w29oLuAdBhSDVb8QjA-JB_MET_F8oHoNE6jxedh_leTw2dFXAKp2T56eeWLP9qoYTDuXj94vLy4vB_ejrRXZw40fur3grAX_GlKBM1IUwA9IPI6sI-6xJEIziaaQ-njW_-vRZ1ohDKojPIhUikwYq3hCrRU3iXWWH0pLWVfmMWpPSxQsNcYsvzyx9mswre6s9KTUFvKyIFzIUtfy3PnqEVEUyIJEYE5HQKJ4i6VHBVkUiziC_8aqHC2UaYQnn5Lm2JgSeT6yo6898F1vbxSXHsws1Vksv6S32dL1Lt9X0aMiupyKgHusgqyJHYSfPtbSK9VKqVfVcB31IXZLIrh7rIGd3b3mAV28llWysFqUvPJBGDk7T9xneNktW9oLRbKAOwVs8I09OHhWlGwgz6UBNx0mqWUWn8F5LV_grBaWh_PcKeqjyFr6SIb-Pr-k06mJ64u1-XZctXSBX6_H6SrkeKXWWnuiwdG9RcxnSCszbuNCrKUlyAUQJUbrPrekoMgb3n7jvyfigXGZjsF7Q4O7j-8nIK7p_ApnsEvb7acmiLlnp5LkSPTk9LWA_CB-7C-8jgj72Pgroau-jIEvPN2OPsxpkvLP82M53nkar8rVRLfzsAumbKahrrm9GlzfmNLGrQj_YszzwzmN_NlIrfoo4GII2csfQI_VaKDmrjfDxPloqLf5JgiaHevIngIUAUPxNYA1CkMavskLxrZSyC-hXlDCxuOOcvY_g5k8d9YltcU_q8nhFAi-ldluuzt-qPS4iICo71EP8kVL0rlnKG8S76Jy20g3dqbyKZEwW_LnvPaGN3oPCo2yWHo1gS0OSZMzwYthqRQOvdHnpCxfq3hNSTl_kPTTcqhm_cZ5eTLKye-MTEcpr45WXVSTaP86aB5bTsQ97R06v3ek5Tld9-Cf-_MLqHDr2ccfq9npmW_bWTluv_kcc_wa-_9ZY

After screenshot:

image image image

Peechey added 2 commits May 12, 2026 11:57
add support for all damage with this weapon can contribute to chill/ignite..
refactor modparser to match all combos of ailments
@Peechey Peechey added the enhancement New feature, calculation, or mod label May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature, calculation, or mod

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant