Speeding up test_mitgcm#2690
Merged
erikvansebille merged 1 commit intoJun 23, 2026
Merged
Conversation
From >30 seconds to ~3 seconds
VeckoTheGecko
approved these changes
Jun 23, 2026
VeckoTheGecko
left a comment
VeckoTheGecko
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me! Great to reduce this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses #2689, by shortening the runtime of
test_mitgcm(). The unit test duration drops from >30 seconds to ~3 seconds; and the total test suite from 89s to 65s.Description
Note that I also had to redo the test_mitgcm in v3; and that I initially didn't get equivalent results because I forgot that the
pset.latof v4 should be compared to thepset.lat_nextloopof v3!Checklist
mainfor normal development,v3-supportfor v3 support)AI Disclosure